Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve error message for fastas with missing segment names #3769

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Improve error message for fastas with missing segment names #3769

wants to merge 2 commits into from
+12 −1

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Feb 26, 2025 •
edited
Loading

resolves #3683

preview URL: https://better-error-msg.loculus.org

Summary

  • when parsing the fasta headers, already check that the segment ID is in the list of valid segment IDs.

Screenshot

image image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests.
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

@fhennig fhennig added the preview Triggers a deployment to argocd label Feb 26, 2025
@fhennig fhennig self-assigned this Feb 26, 2025
@fhennig fhennig marked this pull request as draft February 26, 2025 11:47
@fhennig fhennig mentioned this pull request Feb 26, 2025
Open
@fhennig
Copy link
Contributor Author

fhennig commented Feb 26, 2025

on hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fhennig fhennig

Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clearer error message when sequences submitted without segment identifiers for segmented virus
1 participant
@fhennig