Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip schema validation in helm where possible in various dev environments #3684

Open
theosanderson opened this issue Feb 13, 2025 · 1 comment · Fixed by #3685
Open

Skip schema validation in helm where possible in various dev environments #3684

theosanderson opened this issue Feb 13, 2025 · 1 comment · Fixed by #3685
Labels
blocked Issue cannot be fixed until blocked resolved deployment Code changes targetting the deployment infrastructure

Comments

@theosanderson
Copy link
Member

It's helpful to separate concerns in CI. So for example, we have a CI workflow that checks whether the source code is formatted nicely, but if it's not we can still deploy previews and we can still see if the E2E tests pass. We should do the same for the validation of the helm values. This is achievable and I will make a PR now.
@chaoran-chen chaoran-chen added the deployment Code changes targetting the deployment infrastructure label Feb 13, 2025
@theosanderson theosanderson mentioned this issue Feb 13, 2025
Merged
@theosanderson theosanderson mentioned this issue Feb 14, 2025
Closed
@theosanderson theosanderson reopened this Feb 14, 2025
@theosanderson
Copy link
Member Author

We reverted https://github.com/loculus-project/loculus_toplevel_gitops/pull/2 because it was trying to use a feature that isn't in our older version of ArgoCD, so previews are still schema-fussy for now

@theosanderson theosanderson added the blocked Issue cannot be fixed until blocked resolved label Feb 14, 2025
@theosanderson theosanderson removed their assignment Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Issue cannot be fixed until blocked resolved deployment Code changes targetting the deployment infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(deployment): skip schema validation for dev loculus-project/loculus
2 participants
@chaoran-chen @theosanderson