Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate schema validation errors for dev stuff #3688

Open
theosanderson opened this issue Feb 14, 2025 · 1 comment
Open

Investigate schema validation errors for dev stuff #3688

theosanderson opened this issue Feb 14, 2025 · 1 comment

Comments

@theosanderson
Copy link
Member

We just turned off schema validation for dev workflows: #3685 which I think largely makes sense, for the reasons discussed in the issue, but...

at the same time we realised that the adding of the schema made various dev things fail on main, which was unexpected. We should probably make sure everything on main does obey the schema, even if it's CI stuff.

Failures:
https://github.com/loculus-project/loculus/actions/runs/13308090063/job/37163614481
https://github.com/loculus-project/loculus/actions/runs/13308090052/job/37163617397 (same issue)
https://github.com/loculus-project/loculus/actions/runs/13308090087/job/37163615901 (testconfig)

We could consider specifically running with schema checks for CI runs on main (but that may be unnecessarily complex)

@theosanderson theosanderson changed the title Investigate schema parsing errors for dev stuff Investigate schema validation errors for dev stuff Feb 14, 2025
@theosanderson
Copy link
Member Author

This is where testConfig is used

{{- $keycloakHost := $testconfig | ternary "http://localhost:8083" "http://loculus-keycloak-service:8083" }}
we may be able to refactor this now to be done differnetly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant