Previews fail in 3.7% of cases when first 7 chars of sha are all numeric

[corneliusroemer]

Apparently our previews don't work when the first 7 chars of a sha are all numeric:

Failed to load target state: failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = helm template . --name-template pp-try-leak-fix-3690 --namespace prev-try-leak-fix --kube-version 1.30 --set shortbranch=try-leak-fix --set sha=5486252 --set branch=try-leak-fix --set host=try-leak-fix.loculus.org --values <path to cached source>/kubernetes/loculus/values.yaml --values <path to cached source>/kubernetes/loculus/values_preview_server.yaml <api versions removed> --include-crds failed exit status 1: Error: values don't meet the specifications of the schema(s) in the following chart(s): loculus: - sha: Invalid type. Expected: string, given: integer

The probability of hitting such a sha is (10/16)^7 ~ 3.7%

[corneliusroemer]

Seems to be a bug in #3588 @fhennig

[theosanderson]

huh if this is still manifesting then https://github.com/loculus-project/loculus_toplevel_gitops/pull/2 didn't work

[corneliusroemer]

Yeah, hasn't applied yet: https://argocd.loculus.org/applications/argocd/top-level-git-ops?view=tree&resource=&node=argoproj.io%2FApplicationSet%2Fargocd%2Fpp-preview%2F0

It's not necessarily a bad idea to find out if the schema fails for previews

[theosanderson]

https://github.com/loculus-project/loculus_toplevel_gitops/pull/3

[theosanderson]

It's not necessarily a bad idea to find out if the schema fails for previews

See #3684 - we have specific CI to tell us if the schema is problematic. It's nice to be able to prototype a feature and have a preview without adjusting the schema for every change.

But, yes, we can't do this til we next update argocd