Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): skip schema validation for dev #3685

Merged
merged 5 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-k3d.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
- name: Default template with helm
uses: WyriHaximus/github-action-helm3@v4
with:
exec: helm template loculus kubernetes/loculus
exec: helm template loculus kubernetes/loculus --skip-schema-validation
- name: E2E Template with helm
uses: WyriHaximus/github-action-helm3@v4
with:
Expand Down
6 changes: 4 additions & 2 deletions deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
cluster_parser.add_argument(
"--dev",
action="store_true",
help="Set up a development environment for running the website and the backend locally",
help="Set up a development environment for running the website and the backend locally, skip schema validation",
)
cluster_parser.add_argument("--delete", action="store_true", help="Delete the cluster")

Expand Down Expand Up @@ -91,7 +91,7 @@
help="Just template and print out the YAML produced",
action="store_true",
)
helm_parser.add_argument("--for-e2e", action="store_true", help="Use the E2E values file")
helm_parser.add_argument("--for-e2e", action="store_true", help="Use the E2E values file, skip schema validation")

upgrade_parser = subparsers.add_parser("upgrade", help="Upgrade helm installation")

Expand Down Expand Up @@ -217,6 +217,7 @@ def handle_helm():

if args.for_e2e or args.dev:
parameters += ["-f", HELM_CHART_DIR / "values_e2e_and_dev.yaml"]
parameters += ["--skip-schema-validation"]
if args.sha:
parameters += ["--set", f"sha={args.sha[:7]}"]

Expand Down Expand Up @@ -366,6 +367,7 @@ def generate_config(
helm_chart,
"--show-only",
template,
"--skip-schema-validation"
]

if not output_path:
Expand Down
1 change: 1 addition & 0 deletions kubernetes/loculus/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1762,3 +1762,4 @@ defaultResources:
cpu: "20m"
ingest:
ncbiGatewayUrl: null
nonExistentTest: test
Loading