Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): Add more notifications to the Review page #3773

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Feb 26, 2025

resolves #2561, resolves #3412

preview URL: https://more-toast.loculus.org

Summary

  • Info notifications added on both delete buttons and the release button. (Style of the popups still to be refined)

But I think maybe we don't need this anymore, as deleting and releasing is now very fast? I can't reproduce the 15 second delay, even for 4000 sequences.

IMO I might just close both issues as not relevant anymore.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by appropriate, automated tests.
  • Any manual testing that has been done is documented (i.e. what exactly was tested?)

@fhennig fhennig added the preview Triggers a deployment to argocd label Feb 26, 2025
@fhennig fhennig self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
1 participant