Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation on ubuntu20.04 needs a change in build system #25

Open
bennahugo opened this issue Jan 4, 2022 · 4 comments
Open

Compilation on ubuntu20.04 needs a change in build system #25

bennahugo opened this issue Jan 4, 2022 · 4 comments

Comments

@bennahugo
Copy link
Contributor

bennahugo commented Jan 4, 2022

With the death of python2.7 cmake has removed explicit detection support for it by the looks of it
The following patch is needed to make the build system work for LOFARBeam tag v4.1.1

# fix build system
sed -i '83s/.*/find_package (Boost REQUIRED COMPONENTS python numpy)/' CMakeLists.txt
sed -i '85s/.*/message(STATUS "Boost python library: \${Boost_PYTHON_LIBRARY}")/' CMakeLists.txt
@bennahugo
Copy link
Contributor Author

I'm guessing we can remove support for python2.7 altogether @tammojan? If so I can make a quick fix

@bennahugo bennahugo changed the title Compilation on ubuntu20.04 needs a chage of Compilation on ubuntu20.04 needs a change in build system Jan 4, 2022
@tammojan
Copy link
Contributor

tammojan commented Jan 4, 2022

In fact LOFARBeam was replaced by EveryBeam, which has python bindings as well. Sorry, we should have put a note in the readme here..

If you have a need for LOFARBeam, feel free to remove python2.7 support and I'll merge. But if you can, please have a look at EveryBeam: https://git.astron.nl/RD/EveryBeam

@bennahugo
Copy link
Contributor Author

Thanks @tammojan. I'm busy porting ddfacet and killms over to python3.8 for the next series of LTS support. At this point I'm not looking to make major changes to the codebase, but everybeam is something I would like to put in in the longrun. I will make the changes to the build system and ping when done

@bennahugo
Copy link
Contributor Author

See #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants