Add schema validate

Author: tiensonqin

src/datascript/db.cljc

@@ -1318,7 +1318,7 @@
         (assoc-in db [:schema e-ident a-ident] v-ident)))))
 
 (defn update-rschema [db]
-  (assoc db :rschema (rschema (get-schema db))))
+  (assoc db :rschema (rschema (merge implicit-schema (get-schema db)))))
 
 ;; In context of `with-datom` we can use faster comparators which
 ;; do not check for nil (~10-15% performance gain in `transact`)
@@ -1615,6 +1615,17 @@
                {:error :transact/syntax, :tempids unused})))
     (dissoc report ::value-tempids ::tx-redundant)))
 
+(defn check-schema-update [db entity]
+  (when (ds/schema-entity? entity)
+    (when (and (contains? entity :db/ident)
+               (ds/is-system-keyword? (:db/ident entity)))
+      (raise "Using namespace 'db' for attribute identifiers is not allowed"
+             {:error :transact/schema :entity entity}))
+    (when (or (:db/cardinality entity) (:db/valueType entity))
+      (when-not (ds/schema? entity)
+        (raise "Incomplete schema transaction attributes, expected :db/ident, :db/cardinality"
+               {:error :transact/schema :entity entity})))))
+
 (defn+ transact-tx-data [initial-report initial-es]
   (when-not (or (nil? initial-es)
                 (sequential? initial-es))
@@ -1653,6 +1664,7 @@
 
         (map? entity)
         (let [old-eid (:db/id entity)]
+          (check-schema-update db entity)
           (cond+
             ;; trivial entity
             ; (if (contains? entity :db/id)

src/datascript/schema.cljc

@@ -1,4 +1,21 @@
-(ns datascript.schema)
+(ns datascript.schema
+  (:require [clojure.string]))
+
+(def schema-keys #{:db/ident :db/isComponent :db/noHistory :db/valueType :db/cardinality :db/unique :db/index :db.install/_attribute :db/doc :db/tupleType :db/tupleTypes :db/tupleAttrs})
 
 (defonce schema-attr?
   #{:db/id :db/ident :db/isComponent :db/valueType :db/cardinality :db/unique :db/index :db/doc :db/tupleAttrs  :db/tupleType :db/tupleTypes})
+
+(defn schema?
+  [m]
+  (and (:db/ident m)
+       (:db/cardinality m)))
+
+(defn is-system-keyword? [value]
+  (and (or (keyword? value) (string? value))
+       (if-let [ns (namespace (keyword value))]
+         (= "db" (first (clojure.string/split ns #"\.")))
+         false)))
+
+(defn schema-entity? [entity]
+  (some #(contains? entity %) schema-keys))