Skip to content

SSL settings aren't working when a keystore is provided #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edmocosta opened this issue Sep 13, 2023 · 0 comments · Fixed by #171
Closed

SSL settings aren't working when a keystore is provided #168

edmocosta opened this issue Sep 13, 2023 · 0 comments · Fixed by #171

Comments

@edmocosta
Copy link
Contributor

When an ssl_keystore_path and ssl_keystore_password are provided, the plugin is using the JksSslBuilder to construct the Netty's SslContext. This builder is incomplete and needs to be fixed to behave the same as the SslSimpleBuilder (used for ssl_ceritificate, ssl_key).

Issues that need to be addressed:

  • It's using the ssl_keystore_path certificate file as keystore and truststore
  • All the others ssl_ settings are being ignored and are not working, including client authentication, protocols and cipher suites settings.

Spike branch: undeprecate-keystore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant