Skip to content

Commit b977cc6

Browse files
alees24andreaskurth
authored andcommitted
[usbdev] Remove legacy TODO
Issue #18940 was closed. RTL change was accepted into ES and has also been verified in FPGA numerous times since. Signed-off-by: Adrian Lees <[email protected]>
1 parent 6f1e775 commit b977cc6

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

hw/ip/usbdev/rtl/usb_fs_nb_out_pe.sv

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ module usb_fs_nb_out_pe #(
2828
input logic clk_48mhz_i,
2929
input logic rst_ni,
3030
input logic link_reset_i,
31-
input logic link_active_i,
3231
input logic [6:0] dev_addr_i,
3332

3433
////////////////////////
@@ -333,11 +332,6 @@ module usb_fs_nb_out_pe #(
333332
end
334333
end
335334

336-
// TODO(#18940): Use the link state to prevent the FSM from responding to
337-
// packets until software is ready.
338-
logic unused_link_active_i;
339-
assign unused_link_active_i = ^link_active_i;
340-
341335
always_ff @(posedge clk_48mhz_i or negedge rst_ni) begin
342336
if (!rst_ni) begin
343337
out_xact_state <= StIdle;

hw/ip/usbdev/rtl/usb_fs_nb_pe.sv

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,6 @@ module usb_fs_nb_pe #(
237237
.clk_48mhz_i (clk_48mhz_i),
238238
.rst_ni (rst_ni),
239239
.link_reset_i (link_reset_i),
240-
.link_active_i (link_active_i),
241240
.dev_addr_i (dev_addr_i),
242241

243242
// endpoint interface

0 commit comments

Comments
 (0)