Skip to content

Commit

Permalink
Remove explicit standalone: true (#357)
Browse files Browse the repository at this point in the history
* remove explicit standalone: true and fix failing server test
  • Loading branch information
SimonEntholzer authored Jan 7, 2025
1 parent f02d857 commit 0019b90
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { DecimalPipe } from '@angular/common';
imports: [DecimalPipe],
templateUrl: './ci-status-card.component.html',
styleUrl: './ci-status-card.component.scss',
standalone: true,
})
export class CiStatusCardComponent {
ciStatus = input.required<CiStatus>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { ModeExplanationComponent } from '../mode-explanation/mode-explanation.c
templateUrl: './create-simulation-box.component.html',
styleUrls: ['./create-simulation-box.component.scss'],
imports: [FormsModule, RouterLink, FaIconComponent, ModeExplanationComponent],
standalone: true,
})
export class CreateSimulationBoxComponent implements OnInit {
faEye = faEye;
Expand Down
1 change: 0 additions & 1 deletion src/main/webapp/app/layouts/log-box/log-box.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { DatePipe, NgClass } from '@angular/common';
templateUrl: './log-box.component.html',
styleUrls: ['./log-box.component.scss'],
imports: [NgClass, DatePipe],
standalone: true,
})
export class LogBoxComponent {
logMessages = input<LogMessage[]>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { NgbAlert } from '@ng-bootstrap/ng-bootstrap';
templateUrl: './mode-explanation.component.html',
styleUrls: ['./mode-explanation.component.scss'],
imports: [NgbAlert],
standalone: true,
})
export class ModeExplanationComponent {
readonly mode = input<Mode>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { NgClass } from '@angular/common';
templateUrl: './server-badge.component.html',
styleUrls: ['./server-badge.component.scss'],
imports: [NgClass],
standalone: true,
})
export class ServerBadgeComponent {
readonly server = input<ArtemisServer>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { FormsModule } from '@angular/forms';
templateUrl: './simulation-card.component.html',
styleUrls: ['./simulation-card.component.scss'],
imports: [FaIconComponent, NgbTooltip, NgClass, ServerBadgeComponent, StatusIconComponent, DatePipe, FormsModule],
standalone: true,
})
export class SimulationCardComponent implements OnInit {
faTrashCan = faTrashCan;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ import SharedModule from '../../shared/shared.module';
],
templateUrl: './simulation-schedule-dialog.component.html',
styleUrl: './simulation-schedule-dialog.component.scss',
standalone: true,
})
export class SimulationScheduleDialogComponent implements OnInit {
emailRegex =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { FaIconComponent } from '@fortawesome/angular-fontawesome';
templateUrl: './status-icon.component.html',
styleUrls: ['./status-icon.component.scss'],
imports: [FaIconComponent],
standalone: true,
})
export class StatusIconComponent {
faCircleCheck = faCircleCheck;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export function sortSimulations(simulations: Simulation[]): Simulation[] {
ResultBoxComponent,
DatePipe,
],
standalone: true,
})
export default class SimulationsOverviewComponent implements OnInit {
faSpinner = faSpinner;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,7 @@ public void testCreateCourseAndExam_cleanupEnabled_success() {
);
verify(simulatedArtemisAdmin, times(1)).registerStudentsForExam(1, 1);
verify(simulatedArtemisAdmin, times(1)).prepareExam(1, 1);
verify(simulatedArtemisAdmin, times(1)).cancelAllQueuedBuildJobs();
verify(simulatedArtemisAdmin, times(1)).cancelAllRunningBuildJobs();

// To give Artemis time to cancel all build jobs we extend the timeout beyond 5 seconds
verify(simulatedArtemisAdmin, timeout(13000).times(1)).deleteCourse(1);
verify(simulatedArtemisAdmin, timeout(1000).times(0)).deleteExam(anyLong(), anyLong());
Expand Down

0 comments on commit 0019b90

Please sign in to comment.