Merge pull request #7 from lsxliron/string_as_name_6

Support strings as job names

Author: lsxliron

coveralls.json

@@ -1,7 +1,6 @@
 {
   "skip_files": [
     "test",
-    "lib/quantum_storage_ecto/migrations",
-    "lib/quantum_storage_ecto/types"
+    "lib/quantum_storage_ecto/migrations"
   ]
 }

lib/quantum_storage_ecto/types/atom_or_ref.ex

@@ -19,6 +19,14 @@ defmodule QuantumStorageEcto.Types.AtomOrRef do
     Types.Atom.cast(value)
   end
 
+  def cast(value) when is_binary(value) do
+    if value |> String.starts_with?("#Reference<") do
+      Types.Reference.cast(value)
+    else
+      Types.Atom.cast(value)
+    end
+  end
+
   def cast(_), do: :error
 
   def load(value) when is_binary(value) do

lib/quantum_storage_ecto/types/reference.ex

@@ -11,7 +11,11 @@ defmodule QuantumStorageEcto.Types.Reference do
   def cast(value) when is_reference(value), do: {:ok, value}
 
   def cast(value) when is_binary(value) do
-    {:ok, value |> String.to_charlist() |> :erlang.list_to_ref()}
+    {:ok,
+     value
+     |> String.replace("#Reference<", "#Ref<")
+     |> String.to_charlist()
+     |> :erlang.list_to_ref()}
   end
 
   def cast(_), do: :error

mix.exs

@@ -1,7 +1,7 @@
 defmodule QuantumStorageEcto.MixProject do
   use Mix.Project
 
-  @version "0.1.0"
+  @version "0.1.1"
 
   def project do
     [

test/quantum_storage_ecto/types/atom_or_ref_test.exs

@@ -0,0 +1,42 @@
+defmodule QuantumStorageEcto.Types.AtomOrRefTest do
+  use ExUnit.Case, async: true
+  use QuantumStorageEcto.DataCase
+  import Crontab.CronExpression
+  alias QuantumStorageEcto.Job
+  alias QuantumStorageEcto.Repo
+
+  setup _ do
+    params = %{
+      schedule: ~e[1 * * * *],
+      task: fn -> :ok end,
+      run_strategy: %Quantum.RunStrategy.Local{}
+    }
+
+    {:ok, %{params: params}}
+  end
+
+  def validate(attrs) do
+    {:ok, _} =
+      %Job{}
+      |> Job.changeset(attrs)
+      |> QuantumStorageEcto.Repo.insert()
+
+    refute Job |> Repo.get(attrs.name) |> is_nil()
+  end
+
+  test "can store atom properly", %{params: attrs} do
+    attrs |> Map.put(:name, :test_job_reference) |> validate()
+  end
+
+  test "can store string properly", %{params: attrs} do
+    attrs |> Map.put(:name, "test_job_reference") |> validate()
+  end
+
+  test "can store reference properly", %{params: attrs} do
+    attrs |> Map.put(:name, make_ref()) |> validate()
+  end
+
+  test "can store string reference properly", %{params: attrs} do
+    attrs |> Map.put(:name, "#Reference<0.946883141.702808066.133335>") |> validate()
+  end
+end