Skip to content

Commit 059c565

Browse files
authored
Add donate link to footer (#1127)
## Fixes issue #215 ## Description of Changes Added a `Donate` link to the footer so that it is available on all pages throughout the application instead of just the home page. I also updated the casing of `Download department data` so that it matches the rest of the casing on the footer. ## Screenshots (if appropriate) Before: <img width="1470" alt="Screenshot 2024-10-03 at 4 25 31 PM" src="https://github.com/user-attachments/assets/62f9b72c-f72d-437b-86ce-60a350f16101"> After: <img width="1470" alt="Screenshot 2024-10-03 at 4 26 08 PM" src="https://github.com/user-attachments/assets/92ffee96-1594-4adc-97be-d965ee87c3d0"> ## Tests and Linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
1 parent 710019e commit 059c565

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

OpenOversight/app/templates/base.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,9 @@ <h5>OpenOversight</h5>
150150
<br>
151151
<a href="https://lucyparsonslabs.com/" target="_blank">Lucy Parsons Labs</a>
152152
<br>
153-
<a href="{{ url_for("main.all_data") }}" target="_blank">Download department data</a>
153+
<a href="https://lucyparsonslabs.com/donate" target="_blank">Donate</a>
154+
<br>
155+
<a href="{{ url_for("main.all_data") }}" target="_blank">Download Department Data</a>
154156
</p>
155157
</div>
156158
<div class="col-sm-4">

OpenOversight/tests/routes/test_other.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@ def test_routes_ok(route, client, mockdata):
2727
rv = client.get(route)
2828
assert rv.status_code == HTTPStatus.OK
2929

30+
# Assert donate link is in all base pages
31+
assert (
32+
'<a href="https://lucyparsonslabs.com/donate" target="_blank">Donate</a>'
33+
in rv.data.decode()
34+
)
35+
3036

3137
def test_user_can_access_profile(client, session):
3238
with current_app.test_request_context():

0 commit comments

Comments
 (0)