Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading a portrait format the previous landscape isn't cleared in preview #32

Closed
stefonarch opened this issue Feb 1, 2025 · 3 comments

Comments

@stefonarch
Copy link

stefonarch commented Feb 1, 2025

Image

Showing the image or changing preview size fixes it. I didn't see that before the latest commits. It's possible to make a pile of 4 images.

@stefonarch
Copy link
Author

stefonarch commented Feb 1, 2025

In the viewer same issue I see now, images with a different size doesn't clean the background.

EDIT: no idea why I didn't see it yesterday. It depends on the compositor again. Labwc is fine, kwin_wayland, Hyprland and niri not.

@luebking
Copy link
Owner

luebking commented Feb 1, 2025

I was gonna say before I saw your edit.
QOpenGLWidget defaults to QOpenGLWidget::NoPartialUpdate and it's now autofilled, but maybe a complete manual wipe is inevitable.

If you restore "painter.fillRect(rect(), palette().color(backgroundRole()));" from #28 (comment) is it gone?

@stefonarch
Copy link
Author

Yes, that works fine on Niri and kwin_wayland, probably everywhere.

luebking added a commit that referenced this issue Feb 1, 2025
@luebking luebking closed this as completed Feb 1, 2025
@stefonarch stefonarch mentioned this issue Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants