fix: missing safe execute blocks can cause customer code crash (#811)

* fix: missing safe execute blocks can cause customer code crash
* fix: pin pip3 version required by fastapi old versions
* ci: fix old circle ci flow fails when building lambda java tracer

Author: sagivoululumigo

.circleci/config.yml

@@ -33,50 +33,44 @@ workflows:
     - lumigo-orb/be-deploy:
         context: common
         skip_on_auto_test_update: true
+        save_project_folder: false
         requires:
           - lumigo-orb/is_environment_available
 
-    - lumigo-orb/pre_build_artifacts:
+    - lumigo-orb/prep-it-resources:
         context: common
-        skip_on_auto_test_update: true
         requires:
           - lumigo-orb/is_environment_available
 
-    - lumigo-orb/integration-test-prep:
+    - lumigo-orb/prep-k8s-and-operator:
         context: common
-        pre_builds_available: true
-        run_test_cleanup: false
-        skip_on_auto_test_update: true
         requires:
-          - lumigo-orb/be-deploy
-          - lumigo-orb/pre_build_artifacts
+          - lumigo-orb/is_environment_available
 
-    - lumigo-orb/integration-test-cleanup:
-        name: pre-test-cleanup
+    - lumigo-orb/integration-test-parallel:
         context: common
+        run_test_cleanup: false
         skip_on_auto_test_update: true
         requires:
-          - lumigo-orb/integration-test-prep
+          - lumigo-orb/be-deploy
+          - lumigo-orb/prep-it-resources
+          - lumigo-orb/prep-k8s-and-operator
 
-    - lumigo-orb/integration-test-parallel:
+    - lumigo-orb/e2e-test:
         context: common
-        run_test_cleanup: false
         skip_on_auto_test_update: true
         requires:
-          - pre-test-cleanup
+          - lumigo-orb/be-deploy
+          - lumigo-orb/prep-it-resources
+          - lumigo-orb/prep-k8s-and-operator
 
     - lumigo-orb/integration-test-cleanup:
         name: post-test-cleanup
         context: common
         skip_on_auto_test_update: true
         requires:
           - lumigo-orb/integration-test-parallel
-
-    - lumigo-orb/e2e-test:
-        context: common
-        skip_on_auto_test_update: true
-        requires:
-          - pre-test-cleanup
+          - lumigo-orb/e2e-test
 
     - lumigo-orb/workflow-completed-successfully:
         context: common

noxfile.py

@@ -347,6 +347,7 @@ def integration_tests_fastapi(
     fastapi_version,
     uvicorn_version,
 ):
+    install_package("pip", "24.0", session)
     install_package("uvicorn", uvicorn_version, session)
     install_package("fastapi", fastapi_version, session)
 

src/lumigo_opentelemetry/instrumentations/kafka_python/__init__.py

@@ -30,7 +30,8 @@ def _produce_hook(span: Span, args: List[Any], kwargs: Dict[Any, Any]) -> None:
         def _consume_hook(
             span: Span, record: ABCRecord, args: List[Any], kwargs: Dict[Any, Any]
         ) -> None:
-            add_body_attribute(span, record.value, "messaging.consume.body")
+            with lumigo_safe_execute("kafka _consume_hook"):
+                add_body_attribute(span, record.value, "messaging.consume.body")
 
         KafkaInstrumentor().instrument(
             produce_hook=_produce_hook, consume_hook=_consume_hook

src/lumigo_opentelemetry/instrumentations/pika/__init__.py

@@ -3,6 +3,7 @@
 from lumigo_opentelemetry.instrumentations.instrumentation_utils import (
     add_body_attribute,
 )
+from lumigo_opentelemetry.libs.general_utils import lumigo_safe_execute
 
 
 class PikaInstrumentor(AbstractInstrumentor):
@@ -17,10 +18,12 @@ def install_instrumentation(self) -> None:
         from pika.spec import BasicProperties
 
         def publish_hook(span: Span, body: bytes, properties: BasicProperties) -> None:
-            add_body_attribute(span, body, "messaging.publish.body")
+            with lumigo_safe_execute("pika_publish_hook"):
+                add_body_attribute(span, body, "messaging.publish.body")
 
         def consume_hook(span: Span, body: bytes, properties: BasicProperties) -> None:
-            add_body_attribute(span, body, "messaging.consume.body")
+            with lumigo_safe_execute("pika_consume_hook"):
+                add_body_attribute(span, body, "messaging.consume.body")
 
         PikaInstrumentor().instrument(
             publish_hook=publish_hook,

src/lumigo_opentelemetry/instrumentations/redis/__init__.py

@@ -6,6 +6,7 @@
 from lumigo_opentelemetry.instrumentations.instrumentation_utils import (
     add_body_attribute,
 )
+from lumigo_opentelemetry.libs.general_utils import lumigo_safe_execute
 
 
 class RedisInstrumentor(AbstractInstrumentor):
@@ -22,13 +23,15 @@ def install_instrumentation(self) -> None:
         def request_hook(
             span: Span, instance: Connection, args: List[Any], kwargs: Dict[Any, Any]
         ) -> None:
-            # a db.statement attribute is automatically added by the RedisInstrumentor
-            # when this hook is called, but only includes the command name for some
-            # versions so we need to set it ourselves.
-            add_body_attribute(span, " ".join(args), "db.statement")
+            with lumigo_safe_execute("redis_request_hook"):
+                # a db.statement attribute is automatically added by the RedisInstrumentor
+                # when this hook is called, but only includes the command name for some
+                # versions so we need to set it ourselves.
+                add_body_attribute(span, " ".join(args), "db.statement")
 
         def response_hook(span: Span, instance: Connection, response: Any) -> None:
-            add_body_attribute(span, response, "db.response.body")
+            with lumigo_safe_execute("redis_response_hook"):
+                add_body_attribute(span, response, "db.response.body")
 
         RedisInstrumentor().instrument(
             request_hook=request_hook,