fix potential null pointer deref found by coverity (#188)

chipitsine · web-flow · commit 5fe9f7494267 · 2024-10-07T08:30:32.000+01:00
CID 442487: (#1 of 1): Explicit null dereferenced (FORWARD_NULL) 5. var_deref_model: Passing null pointer pout to SQLInstallDriverEx, which dereferences it. [Note: The source code implementation of the function has been overridden by a builtin model.] 251 ret = SQLInstallDriverEx( drv, pth, pout, cbPathOutMax, &len, fRequest, lpdwUsageCount );
diff --git a/odbcinst/SQLInstallDriverEx.c b/odbcinst/SQLInstallDriverEx.c
@@ -248,7 +248,7 @@ BOOL INSTAPI SQLInstallDriverExW(LPCWSTR lpszDriver,
 		pout = NULL;
 	}
 
-	ret = SQLInstallDriverEx( drv, pth, pout, cbPathOutMax, &len, fRequest, lpdwUsageCount );
+	ret = pout ? SQLInstallDriverEx( drv, pth, pout, cbPathOutMax, &len, fRequest, lpdwUsageCount ) : FALSE;
 
 	if ( ret )
 	{

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ BOOL INSTAPI SQLInstallDriverExW(LPCWSTR lpszDriver,`
`248`	`248`	`pout = NULL;`
`249`	`249`	`}`
`250`	`250`
`251`		`- ret = SQLInstallDriverEx( drv, pth, pout, cbPathOutMax, &len, fRequest, lpdwUsageCount );`
	`251`	`+ ret = pout ? SQLInstallDriverEx( drv, pth, pout, cbPathOutMax, &len, fRequest, lpdwUsageCount ) : FALSE;`
`252`	`252`
`253`	`253`	`if ( ret )`
`254`	`254`	`{`