Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation space dimension wrong? #1

Open
baoyunfan opened this issue Mar 2, 2018 · 1 comment
Open

Observation space dimension wrong? #1

baoyunfan opened this issue Mar 2, 2018 · 1 comment

Comments

@baoyunfan
Copy link

It looks like the env returns observation space shape of Box(480, 640, 3), while the actual frame returned by step() has a shape of (200, 400, 3). For me the frames need to be rotated 90 degrees clockwise to match the actual game screen.

The obs space dimensions seem to be hard-wired in tetris_env.py. I wonder if line 6 should be instead,
SCREEN_WIDTH, SCREEN_HEIGHT = 200,400
Also, line 17 should be,
self.observation_space = spaces.Box(low=0, high=255, shape=(SCREEN_WIDTH, SCREEN_HEIGHT, 3))

Thanks!

@lusob
Copy link
Owner

lusob commented Mar 5, 2018

Hi! @baoyunfan
Could you make a pull request with the patch?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants