Skip to content
This repository has been archived by the owner on Feb 14, 2025. It is now read-only.

Profiling credentials #424

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Profiling credentials #424

merged 5 commits into from
Apr 8, 2024

Conversation

alejandroroiz
Copy link
Contributor

Add a timer stat to update and create credentials

authnz.get_logged_in_user()
with stats.timer('create_credential'):
if not acl_module_check(resource_type='credential', action='create'):
msg = "{} does not have access to create credentials".format(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would be good to start using f-strings in confidant. no need to change it for now but at least code that we touch in the future or add.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, will start focusing on this

@alejandroroiz alejandroroiz merged commit cb10bb5 into master Apr 8, 2024
7 checks passed
@alejandroroiz alejandroroiz deleted the profiling-credentials branch April 8, 2024 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants