Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 4 Feedback #5

Open
codepathreview opened this issue Oct 9, 2017 · 0 comments
Open

Project 4 Feedback #5

codepathreview opened this issue Oct 9, 2017 · 0 comments

Comments

@codepathreview
Copy link

codepathreview commented Oct 9, 2017

👍 Great work. A few notes after checking out the code:

  • Nice to see you used a drawable and/or styles to customize the view
  • Great effort on UI polish. Looks neat.
  • Glad to see you properly hooked up each of the different timelines to infinitely paginate.
  • Good to see you properly communicated the user to the user timeline fragment from the profile activity.
  • Nice to see you used the ViewPager to properly setup the tabs
  • Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then use abstract methods to define only the specific behavior where they differ. You are on the right track but still have some code duplication which can be moved to base fragment

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant