fix: Update placementAttributes to placementAttributesMapping

Author: BrandonStalnaker

UnitTests/MPRoktTests.m

@@ -3,9 +3,10 @@
 #import "MParticle.h"
 #import "MPKitContainer.h"
 #import "MPForwardQueueParameters.h"
+#import "MPIConstants.h"
 
 @interface MPRokt ()
-- (NSArray<NSDictionary<NSString *, NSString *> *> *)getRoktPlacementAttributes;
+- (NSArray<NSDictionary<NSString *, NSString *> *> *)getRoktPlacementAttributesMapping;
 @end
 
 @interface MPRokt (Testing)
@@ -30,7 +31,7 @@ - (void)tearDown {
 }
 
 - (void)testSelectPlacementsSimpleWithValidParameters {
-    [[[self.mockRokt stub] andReturn:@[]] getRoktPlacementAttributes];
+    [[[self.mockRokt stub] andReturn:@[]] getRoktPlacementAttributesMapping];
     MParticle *instance = [MParticle sharedInstance];
     id mockInstance = OCMPartialMock(instance);
     id mockContainer = OCMClassMock([MPKitContainer_PRIVATE class]);
@@ -74,7 +75,7 @@ - (void)testSelectPlacementsSimpleWithValidParameters {
 }
 
 - (void)testSelectPlacementsExpandedWithValidParameters {
-    [[[self.mockRokt stub] andReturn:@[]] getRoktPlacementAttributes];
+    [[[self.mockRokt stub] andReturn:@[]] getRoktPlacementAttributesMapping];
     MParticle *instance = [MParticle sharedInstance];
     id mockInstance = OCMPartialMock(instance);
     id mockContainer = OCMClassMock([MPKitContainer_PRIVATE class]);
@@ -132,7 +133,7 @@ - (void)testSelectPlacementsExpandedWithValidParameters {
 }
 
 - (void)testSelectPlacementsExpandedWithNilParameters {
-    [[[self.mockRokt stub] andReturn:@[]] getRoktPlacementAttributes];
+    [[[self.mockRokt stub] andReturn:@[]] getRoktPlacementAttributesMapping];
     MParticle *instance = [MParticle sharedInstance];
     id mockInstance = OCMPartialMock(instance);
     id mockContainer = OCMClassMock([MPKitContainer_PRIVATE class]);
@@ -184,7 +185,7 @@ - (void)testSelectPlacementsExpandedWithNilParameters {
 }
 
 - (void)testSelectPlacementsSimpleWithMapping {
-    [[[self.mockRokt stub] andReturn:@[@{@"map": @"f.name", @"maptype": @"UserAttributeClass.Name", @"value": @"firstname"}, @{@"map": @"zip", @"maptype": @"UserAttributeClass.Name", @"value": @"billingzipcode"}, @{@"map": @"l.name", @"maptype": @"UserAttributeClass.Name", @"value": @"lastname"}]] getRoktPlacementAttributes];
+    [[[self.mockRokt stub] andReturn:@[@{@"map": @"f.name", @"maptype": @"UserAttributeClass.Name", @"value": @"firstname"}, @{@"map": @"zip", @"maptype": @"UserAttributeClass.Name", @"value": @"billingzipcode"}, @{@"map": @"l.name", @"maptype": @"UserAttributeClass.Name", @"value": @"lastname"}]] getRoktPlacementAttributesMapping];
     MParticle *instance = [MParticle sharedInstance];
     id mockInstance = OCMPartialMock(instance);
     id mockContainer = OCMClassMock([MPKitContainer_PRIVATE class]);
@@ -229,7 +230,7 @@ - (void)testSelectPlacementsSimpleWithMapping {
 }
 
 - (void)testSelectPlacementsSimpleWithNilMapping {
-    [[[self.mockRokt stub] andReturn:nil] getRoktPlacementAttributes];
+    [[[self.mockRokt stub] andReturn:nil] getRoktPlacementAttributesMapping];
     MParticle *instance = [MParticle sharedInstance];
     id mockInstance = OCMPartialMock(instance);
     id mockContainer = OCMClassMock([MPKitContainer_PRIVATE class]);
@@ -255,15 +256,15 @@ - (void)testSelectPlacementsSimpleWithNilMapping {
     OCMVerifyAll((id)mockContainer);
 }
 
-- (void)testGetRoktPlacementAttributes {
+- (void)testGetRoktPlacementAttributesMapping {
     MParticle *instance = [MParticle sharedInstance];
     id mockInstance = OCMPartialMock(instance);
     id mockContainer = OCMClassMock([MPKitContainer_PRIVATE class]);
     NSArray *kitConfig = @[@{
         @"AllowJavaScriptResponse": @"True",
         @"accountId": @12345,
         @"onboardingExpProvider": @"None",
-        @"placementAttributes": @"[{\"jsmap\":null,\"map\":\"f.name\",\"maptype\":\"UserAttributeClass.Name\",\"value\":\"firstname\"},{\"jsmap\":null,\"map\":\"zip\",\"maptype\":\"UserAttributeClass.Name\",\"value\":\"billingzipcode\"},{\"jsmap\":null,\"map\":\"l.name\",\"maptype\":\"UserAttributeClass.Name\",\"value\":\"lastname\"}]",
+        kMPPlacementAttributesMapping: @"[{\"jsmap\":null,\"map\":\"f.name\",\"maptype\":\"UserAttributeClass.Name\",\"value\":\"firstname\"},{\"jsmap\":null,\"map\":\"zip\",\"maptype\":\"UserAttributeClass.Name\",\"value\":\"billingzipcode\"},{\"jsmap\":null,\"map\":\"l.name\",\"maptype\":\"UserAttributeClass.Name\",\"value\":\"lastname\"}]",
         @"sandboxMode": @"True",
         @"eau": @0,
         @"hs": @{
@@ -276,7 +277,7 @@ - (void)testGetRoktPlacementAttributes {
     [[[mockInstance stub] andReturn:mockContainer] kitContainer_PRIVATE];
     [[[mockInstance stub] andReturn:mockInstance] sharedInstance];
 
-    NSArray<NSDictionary<NSString *, NSString *> *> *testResult = [self.rokt getRoktPlacementAttributes];
+    NSArray<NSDictionary<NSString *, NSString *> *> *testResult = [self.rokt getRoktPlacementAttributesMapping];
     NSArray<NSDictionary<NSString *, NSString *> *> *expectedResult = @[@{@"map": @"f.name", @"maptype": @"UserAttributeClass.Name", @"value": @"firstname", @"jsmap": [NSNull null]}, @{@"map": @"zip", @"maptype": @"UserAttributeClass.Name", @"value": @"billingzipcode", @"jsmap": [NSNull null]}, @{@"map": @"l.name", @"maptype": @"UserAttributeClass.Name", @"value": @"lastname", @"jsmap": [NSNull null]}];
 
     XCTAssertEqualObjects(testResult, expectedResult, @"Mapping does not match .");

mParticle-Apple-SDK/MPIConstants.h

@@ -516,4 +516,7 @@ extern NSString * _Nonnull const kMPDeviceIdentifierKey;
 extern NSString * _Nonnull const kMPDeviceLimitAdTrackingKey;
 extern NSString * _Nonnull const kMPDeviceIsDaylightSavingTime;
 extern NSString * _Nonnull const kMPDeviceInvalidVendorId;
+
+// MPRokt Constants
+extern NSString * _Nonnull const kMPPlacementAttributesMapping;
 #endif

mParticle-Apple-SDK/MPIConstants.m

@@ -415,6 +415,10 @@
 NSString * const kMPDeviceLimitAdTrackingKey = @"lat";
 NSString * const kMPDeviceIsDaylightSavingTime = @"idst";
 NSString * const kMPDeviceInvalidVendorId = @"00000000-0000-0000-0000-000000000000";
+
+// MPRokt Constants
+NSString * const kMPPlacementAttributesMapping = @"placementAttributesMapping";
+
 //
 // Primitive data type constants
 //

mParticle-Apple-SDK/mParticle.m

@@ -178,7 +178,7 @@ - (void)selectPlacements:(NSString *)identifier
 onShouldShowLoadingIndicator:(void (^ _Nullable)(void))onShouldShowLoadingIndicator
 onShouldHideLoadingIndicator:(void (^ _Nullable)(void))onShouldHideLoadingIndicator
     onEmbeddedSizeChange:(void (^ _Nullable)(NSString * _Nonnull, CGFloat))onEmbeddedSizeChange {
-    NSArray<NSDictionary<NSString *, NSString *> *> *attributeMap = [self getRoktPlacementAttributes];
+    NSArray<NSDictionary<NSString *, NSString *> *> *attributeMap = [self getRoktPlacementAttributesMapping];
 
     // If attributeMap is nil the kit hasn't been initialized
     if (attributeMap) {
@@ -221,7 +221,7 @@ - (void)selectPlacements:(NSString *)identifier
     }
 }
 
-- (NSArray<NSDictionary<NSString *, NSString *> *> *)getRoktPlacementAttributes {
+- (NSArray<NSDictionary<NSString *, NSString *> *> *)getRoktPlacementAttributesMapping {
     NSArray<NSDictionary<NSString *, NSString *> *> *attributeMap = nil;
 
     // Get the kit configuration
@@ -239,8 +239,8 @@ - (void)selectPlacements:(NSString *)identifier
     if (roktKitConfig != nil) {
         // Rokt Kit is available though there may not be an attribute map
         attributeMap = @[];
-        if (roktKitConfig[@"placementAttributes"] != [NSNull null]) {
-            strAttributeMap = [roktKitConfig[@"placementAttributes"] stringByRemovingPercentEncoding];
+        if (roktKitConfig[kMPPlacementAttributesMapping] != [NSNull null]) {
+            strAttributeMap = [roktKitConfig[kMPPlacementAttributesMapping] stringByRemovingPercentEncoding];
             dataAttributeMap = [strAttributeMap dataUsingEncoding:NSUTF8StringEncoding];
         }
     }