fixed issue with "nan" being displayed in table for non-existing locales

closes #11

Author: ma4nn

README.md

@@ -106,7 +106,7 @@ e.g. a good starting point is [list_accounts.py](https://github.com/ma4nn/pp-ter
 
 The app uses [Typer](https://typer.tiangolo.com/) for composing the commands and [Rich](https://github.com/Textualize/rich)
 for nice console outputs. The Portfolio Performance XML file is read with [ppxml2db](https://github.com/pfalcon/ppxml2db) 
-and efficiently held in [panda dataframes](https://pandas.pydata.org/).
+and efficiently held in [pandas dataframes](https://pandas.pydata.org/).
 
 If your command makes sense for a broader audience, I'm happy to accept a pull request.
 

pp_terminal/helper.py

@@ -38,13 +38,16 @@ def currency_exists(currency_code: str, locale: str | None = None) -> bool:
 
 
 def format_money(value: Money, currency: str = '', locale: str | None = babel.numbers.LC_NUMERIC) -> str:
+    if pd.isna(value) or not isinstance(value, Money):
+        return ''
+
     try:
         currency = currency if not pd.isna(currency) and currency_exists(currency, locale) else ''
 
-        return format_currency(value, currency, locale=locale) if not pd.isna(value) and isinstance(value, Money) else ''
+        return format_currency(value, currency, locale=locale)
     except Exception:  # pylint: disable=broad-exception-caught
         # fallback e.g. if system locale is None/not set, or currency does not exist
-        return f"{value:.2f}" if isinstance(value, Money) else ''
+        return f"{value:.2f}"
 
 
 def enum_types_to_name(enum_list: List[Any]) -> List[Any]:

tests/test_helper.py

@@ -37,6 +37,7 @@
     ('', None, 'EUR', 'en_US'),
     ('', 9, 'EUR', 'fr_FR'),
     ('', object(), 'EUR', 'fr_FR'),
+    ('', float('nan'), 'EUR', None),
 ])
 def test_format_money(expected: str, money: Money, currency: str, locale_value: str) -> None:
     assert format_money(money, currency, locale_value) == expected