From 38736908ca00132fd525fd66f5b15b23e7dd6afa Mon Sep 17 00:00:00 2001 From: Daniel Krebs Date: Mon, 18 Nov 2024 11:12:38 +0100 Subject: [PATCH] Fix filtering only `participating` notifications. The actual query parameter was missing. --- src/main/typescript/client/GitHubClientImpl.ts | 2 +- src/test/resources/client/github-client-scenarios.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/typescript/client/GitHubClientImpl.ts b/src/main/typescript/client/GitHubClientImpl.ts index d9316e5..49bce52 100644 --- a/src/main/typescript/client/GitHubClientImpl.ts +++ b/src/main/typescript/client/GitHubClientImpl.ts @@ -65,7 +65,7 @@ export class GitHubClientImpl implements GitHubClient { public async listThreads(showParticipatingOnly: boolean = false): Promise { const response = await this.doRequest( HttpMethod.GET, - `https://${this.baseUrl}/notifications?${showParticipatingOnly.toString()}`, + `https://${this.baseUrl}/notifications?participating=${showParticipatingOnly.toString()}`, [HttpStatus.Ok] ); diff --git a/src/test/resources/client/github-client-scenarios.json b/src/test/resources/client/github-client-scenarios.json index 29a3cf8..0b98fe7 100644 --- a/src/test/resources/client/github-client-scenarios.json +++ b/src/test/resources/client/github-client-scenarios.json @@ -1,7 +1,7 @@ { "fetch-all-threads": { "request": { - "url": "https://api.github.com/notifications?false", + "url": "https://api.github.com/notifications?participating=false", "method": "GET", "headers": { "Authorization": "Bearer fake-token", @@ -183,7 +183,7 @@ }, "fetch-threads-fails": { "request": { - "url": "https://api.github.com/notifications?false", + "url": "https://api.github.com/notifications?participating=false", "method": "GET", "headers": { "Authorization": "Bearer fake-token",