qt4-mac: allow building on Tahoe

Also remove old workarounds and consolidate deployment target capping.

Closes: https://trac.macports.org/ticket/73278

Author: jmroot

aqua/qt4-mac/Portfile

@@ -6,7 +6,6 @@ PortSystem          1.0
 # does not include certain parts
 set building_qt4    1
 PortGroup           qt4 1.0
-PortGroup           xcodeversion 1.0
 
 name                qt4-mac
 version             4.8.7
@@ -32,10 +31,7 @@ checksums           rmd160 afb5e5a99388e6429faca59cb5000054feffd166 \
                     sha256 e2882295097e47fe089f8ac741a95fef47e0a73a3f3cdf21b56990638f626ea0 \
                     size   241075567
 
-if {[info exists use_xcode]} {
-    use_xcode           yes
-}
-minimum_xcodeversions   {8 2.5}
+use_xcode           yes
 
 depends_lib-append  port:zlib \
                     path:bin/dbus-daemon:dbus \
@@ -55,15 +51,10 @@ platform darwin 10 {
 
 # easy solution for deprecated font API; see also
 # https://trac.macports.org/ticket/66114
-
-platform darwin 22 {
-     macosx_deployment_target 12.0
-}
-platform darwin 23 {
-     macosx_deployment_target 12.0
-}
-platform darwin 24 {
-     macosx_deployment_target 12.0
+platform darwin {
+    if {[vercmp $macosx_deployment_target > 12.0]} {
+        macosx_deployment_target 12.0
+    }
 }
 
 # find a way to specify the OS MINOR version.  For OSX 10.X, this
@@ -93,20 +84,6 @@ if {${macosx_deployment_target} ne ""} {
 }
 # ui_debug "Deduced OS MAJOR.MINOR = ${MAJOR}.${MINOR}"
 
-# Error out if trying to build on a new macOS version. We do this
-# because this port is so old and thus we want to make sure this
-# port works on these newer macOS versions first.
-platform darwin {
-    if { ${os.major} > 24 } {
-        depends_lib
-        depends_run
-        pre-fetch {
-            ui_error "$name does not currently build on macOS versions later than 15 Sequoia."
-            error "unsupported platform"
-        }
-    }
-}
-
 ###############################################
 # Patches are used to both fix compiling on various OS versions, and
 # to enhance the functionality of QMake and its build files.  Some of
@@ -426,6 +403,9 @@ patchfiles-append patch-test_compiler_version.diff
 # we'll add an "if" to narrow the scope of application
 patchfiles-append patch-src_3rdparty_javascriptcore_JavaScriptCore_jit_JITStubs.cpp_remove_volatile.diff
 
+# fix "error: expression is not an integral constant expression"
+patchfiles-append qcoloroutput_p.h-shift.patch
+
 # the wtf_ceil workaround in wtf/MathExtras.h is causing a build error with Xcode 15
 # this workaround was deleted long ago here in the upstream source:
 # (wtf_ceil): Deleted. This was a workaround for a bug that was introduced in Leopard and
@@ -438,6 +418,9 @@ platform darwin {
     if { ${os.major} > 22 } {
         patchfiles-append patch-webkit-remove-wtf_ceil-workaround.diff
     }
+    if {${os.major} >= 25} {
+        patchfiles-append no-AGL.patch
+    }
 }
 
 # Support aarch64

aqua/qt4-mac/files/no-AGL.patch

@@ -0,0 +1,20 @@
+--- mkspecs/common/mac.conf.orig	2025-11-30 09:40:09
++++ mkspecs/common/mac.conf	2025-11-30 09:47:01
+@@ -10,15 +10,14 @@
+ QMAKE_INCDIR_QT		= $$[QT_INSTALL_HEADERS]
+ QMAKE_LIBDIR_QT		= $$[QT_INSTALL_LIBS]
+ QMAKE_FRAMEWORKDIR_QT	= $$[QT_INSTALL_FRAMEWORKS]
+-QMAKE_INCDIR_OPENGL	= /System/Library/Frameworks/OpenGL.framework/Headers \
+-	/System/Library/Frameworks/AGL.framework/Headers/
++QMAKE_INCDIR_OPENGL	= /System/Library/Frameworks/OpenGL.framework/Headers
+ 
+ QMAKE_FIX_RPATH         = install_name_tool -id 
+ 
+ QMAKE_LFLAGS_RPATH	=
+ 
+ QMAKE_LIBS_DYNLOAD	=
+-QMAKE_LIBS_OPENGL	= -framework OpenGL -framework AGL
++QMAKE_LIBS_OPENGL	= -framework OpenGL
+ QMAKE_LIBS_OPENGL_QT	= $$QMAKE_LIBS_OPENGL
+ QMAKE_LIBS_THREAD	=
+ 

aqua/qt4-mac/files/qcoloroutput_p.h-shift.patch

@@ -0,0 +1,32 @@
+From 7b1f8df5fa8ea5346315f999097b19836d7eac19 Mon Sep 17 00:00:00 2001
+From: Thiago Macieira <[email protected]>
+Date: Fri, 21 Dec 2012 23:47:50 -0800
+Subject: [PATCH] Fix annoying warning in qtxmlpatterns about a value too big
+ for the enum
+
+api/qcoloroutput_p.h:74:60: error: signed shift result (0xFFFFF00000) requires 41 bits to represent, but 'int' only has 32 bits [-Werror,-Wshift-overflow]
+
+The masks don't look right anyway. Let's just hardcode them according
+to how many colours are used.
+
+Change-Id: Idd3438ecab3fb666bd84929fb731011224b9c68e
+Reviewed-by: Lars Knoll <[email protected]>
+---
+ src/xmlpatterns/api/qcoloroutput_p.h | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/xmlpatterns/api/qcoloroutput_p.h b/src/xmlpatterns/api/qcoloroutput_p.h
+index 864b90d9..f02a4506 100644
+--- src/xmlpatterns/api/qcoloroutput_p.h.orig
++++ src/xmlpatterns/api/qcoloroutput_p.h
+@@ -70,8 +70,8 @@ namespace QPatternist
+             ForegroundShift = 10,
+             BackgroundShift = 20,
+             SpecialShift    = 20,
+-            ForegroundMask  = ((1 << ForegroundShift) - 1) << ForegroundShift,
+-            BackgroundMask  = ((1 << BackgroundShift) - 1) << BackgroundShift
++            ForegroundMask  = 0x1f << ForegroundShift,
++            BackgroundMask  = 0x7 << BackgroundShift
+         };
+ 
+     public: