-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI stuck trying to block creature with menace #13290
Comments
Obeka, Splitter of Seconds - (Gatherer) (Scryfall) (EDHREC)
|
* fixed game freezes for no-possible block configurations like Menace (#13290); * fixed computer cheating to ignore block requirements like Menace (now AI will choose all required blockers instead 1); * improved computer logic for blockers selection (try to sacrifice a creature instead game loose, simple use cases only); * added freeze protection for bad or unsupported attacker-block configuration; * refactor: deleted outdated AI code;
AI's blocker logic reworked in 92b7ed8, it must be more stable and compatible. There are still possible no-valid block configurations from AI but it will be visible by game log warning only (without game freeze). |
Looks like blocking problems was one of the main reason of AI game freezes for long time. Now I can run hundreds of random games (ai vs ai) without stuck. ~20 seconds per 1 game. |
* now computer will use simplified 1 vs 1 combat damage simulations to choose better blockers (due better game score after combat); * it's not a full combat simulation, but support many things like non-stack abilities, damage replacement effects and SBA -- much better than older PT compare (related to #13290); * now AI correctly use a blockers with deathtouth, indestructible, first/double strike and other abilities; * chump blocks also supported (chump logic implemented before in 92b7ed8, related to #4485);
It looks like there's still an issue with menace handling on the latest beta release. |
@alexander-novo need battlefield screenshot or description for bad use cases (impossible block message from AI or wrong blocks declare -- it's different problems) |
Here's another example. It seems to get hung up much less frequently before, but I am still noticing a problem with menace (in this screenshot [[Professional Face-Breaker]]). No messages in either console, and it always seems to be the last AI in turn rotation that gets stuck, rather than the one blocking the menace creature. |
Professional Face-Breaker - (Gatherer) (Scryfall) (EDHREC)
|
Maybe related to multiplayer games (multiple opponents). Hmm. |
* fixed game freezes for no-possible block configurations like Menace (magefree#13290); * fixed computer cheating to ignore block requirements like Menace (now AI will choose all required blockers instead 1); * improved computer logic for blockers selection (try to sacrifice a creature instead game loose, simple use cases only); * added freeze protection for bad or unsupported attacker-block configuration; * refactor: deleted outdated AI code;
* now computer will use simplified 1 vs 1 combat damage simulations to choose better blockers (due better game score after combat); * it's not a full combat simulation, but support many things like non-stack abilities, damage replacement effects and SBA -- much better than older PT compare (related to magefree#13290); * now AI correctly use a blockers with deathtouth, indestructible, first/double strike and other abilities; * chump blocks also supported (chump logic implemented before in 92b7ed8, related to magefree#4485);
Tried attacking an AI player with [[Obeka, Splitter of Seconds]] and it got stuck trying to block it with only a single creature. Log instantly filled up with messages as soon as attackers were declared:
I suspect this is due to the AI changes around blockers in the recent update.
The text was updated successfully, but these errors were encountered: