-
Notifications
You must be signed in to change notification settings - Fork 158
/
Copy pathAnnotationFormatValidator.php
379 lines (360 loc) · 13.1 KB
/
AnnotationFormatValidator.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
declare(strict_types=1);
namespace Magento2\Sniffs\Annotation;
use PHP_CodeSniffer\Files\File;
/**
* Class to validate annotation format
*/
class AnnotationFormatValidator
{
/**
* Gets the short description end pointer position
*
* @param File $phpcsFile
* @param int $shortPtr
* @param int $commentEndPtr
* @return int
*/
private function getShortDescriptionEndPosition(File $phpcsFile, int $shortPtr, $commentEndPtr): int
{
$tokens = $phpcsFile->getTokens();
$shortPtrEnd = $shortPtr;
for ($i = ($shortPtr + 1); $i < $commentEndPtr; $i++) {
if ($tokens[$i]['code'] === T_DOC_COMMENT_STRING) {
if ($tokens[$i]['line'] === $tokens[$shortPtrEnd]['line'] + 1) {
$shortPtrEnd = $i;
} else {
break;
}
}
}
return $shortPtrEnd;
}
/**
* Validates whether the short description has multi lines in description
*
* @param File $phpcsFile
* @param int $shortPtr
* @param int $commentEndPtr
*/
private function validateMultiLinesInShortDescription(
File $phpcsFile,
int $shortPtr,
int $commentEndPtr
): void {
$tokens = $phpcsFile->getTokens();
$shortPtrEnd = $this->getShortDescriptionEndPosition(
$phpcsFile,
(int)$shortPtr,
$commentEndPtr
);
$shortPtrEndContent = $tokens[$shortPtrEnd]['content'];
if (preg_match('/^[a-z]/', $shortPtrEndContent)
&& $shortPtrEnd != $shortPtr
&& !preg_match('/\bSee\b/', $shortPtrEndContent)
&& $tokens[$shortPtr]['line'] + 1 === $tokens[$shortPtrEnd]['line']
&& $tokens[$shortPtrEnd]['code'] !== T_DOC_COMMENT_TAG
) {
$error = 'Short description should not be in multi lines';
$phpcsFile->addError($error, $shortPtrEnd + 1, 'MethodAnnotation');
}
}
/**
* Validates whether the spacing between short and long descriptions
*
* @param File $phpcsFile
* @param int $shortPtr
* @param int $commentEndPtr
* @param array $emptyTypeTokens
*/
private function validateSpacingBetweenShortAndLongDescriptions(
File $phpcsFile,
int $shortPtr,
int $commentEndPtr,
array $emptyTypeTokens
): void {
$tokens = $phpcsFile->getTokens();
$shortPtrEnd = $this->getShortDescriptionEndPosition(
$phpcsFile,
(int)$shortPtr,
$commentEndPtr
);
$shortPtrEndContent = $tokens[$shortPtrEnd]['content'];
if (preg_match('/^[A-Z]/', $shortPtrEndContent)
&& !preg_match('/\bSee\b/', $shortPtrEndContent)
&& $tokens[$shortPtr]['line'] + 1 === $tokens[$shortPtrEnd]['line']
&& $tokens[$shortPtrEnd]['code'] !== T_DOC_COMMENT_TAG
) {
$error = 'There must be exactly one blank line between lines short and long descriptions';
$phpcsFile->addError($error, $shortPtrEnd + 1, 'MethodAnnotation');
}
if ($shortPtrEnd != $shortPtr) {
$this->validateLongDescriptionFormat($phpcsFile, $shortPtrEnd, $commentEndPtr, $emptyTypeTokens);
} else {
$this->validateLongDescriptionFormat($phpcsFile, $shortPtr, $commentEndPtr, $emptyTypeTokens);
}
}
/**
* Validates short description format
*
* @param File $phpcsFile
* @param int $shortPtr
* @param int $stackPtr
* @param int $commentEndPtr
* @param array $emptyTypeTokens
*/
private function validateShortDescriptionFormat(
File $phpcsFile,
int $shortPtr,
int $stackPtr,
int $commentEndPtr,
array $emptyTypeTokens
): void {
$tokens = $phpcsFile->getTokens();
if ($tokens[$shortPtr]['line'] !== $tokens[$stackPtr]['line'] + 1) {
$error = 'No blank lines are allowed before short description';
$phpcsFile->addError($error, $shortPtr, 'MethodAnnotation');
}
if (strtolower($tokens[$shortPtr]['content']) === '{@inheritdoc}') {
$error = 'If the @inheritdoc not inline it shouldn’t have braces';
$fix = $phpcsFile->addFixableError($error, $shortPtr, 'MethodAnnotation');
if ($fix === true) {
$phpcsFile->fixer->replaceToken($shortPtr, '@inheritDoc');
}
}
$shortPtrContent = $tokens[$shortPtr]['content'];
if (preg_match('/^\p{Ll}/u', $shortPtrContent) === 1) {
$error = 'Short description must start with a capital letter';
$phpcsFile->addError($error, $shortPtr, 'MethodAnnotation');
}
$this->validateNoExtraNewLineBeforeShortDescription(
$phpcsFile,
$stackPtr,
$commentEndPtr,
$emptyTypeTokens
);
$this->validateSpacingBetweenShortAndLongDescriptions(
$phpcsFile,
$shortPtr,
$commentEndPtr,
$emptyTypeTokens
);
$this->validateMultiLinesInShortDescription(
$phpcsFile,
$shortPtr,
$commentEndPtr
);
}
/**
* Validates long description format
*
* @param File $phpcsFile
* @param int $shortPtrEnd
* @param int $commentEndPtr
* @param array $emptyTypeTokens
*/
private function validateLongDescriptionFormat(
File $phpcsFile,
int $shortPtrEnd,
int $commentEndPtr,
array $emptyTypeTokens
): void {
$tokens = $phpcsFile->getTokens();
$longPtr = $phpcsFile->findNext($emptyTypeTokens, $shortPtrEnd + 1, $commentEndPtr - 1, true);
if (strtolower($tokens[$longPtr]['content']) === '@inheritdoc') {
$error = '@inheritdoc imports only short description, annotation must have long description';
$phpcsFile->addError($error, $longPtr, 'MethodAnnotation');
}
if ($longPtr !== false && $tokens[$longPtr]['code'] === T_DOC_COMMENT_STRING) {
if ($tokens[$longPtr]['line'] !== $tokens[$shortPtrEnd]['line'] + 2) {
$error = 'There must be exactly one blank line between descriptions';
$phpcsFile->addError($error, $longPtr, 'MethodAnnotation');
}
if (preg_match('/^\p{Ll}/u', $tokens[$longPtr]['content']) === 1) {
$error = 'Long description must start with a capital letter';
$phpcsFile->addError($error, $longPtr, 'MethodAnnotation');
}
}
}
/**
* Validates tags spacing format
*
* @param File $phpcsFile
* @param int $commentStartPtr
* @param array $emptyTypeTokens
*/
public function validateTagsSpacingFormat(File $phpcsFile, int $commentStartPtr, array $emptyTypeTokens): void
{
$tokens = $phpcsFile->getTokens();
if (isset($tokens[$commentStartPtr]['comment_tags'][0])) {
$firstTagPtr = $tokens[$commentStartPtr]['comment_tags'][0];
$commentTagPtrContent = $tokens[$firstTagPtr]['content'];
$prevPtr = $phpcsFile->findPrevious($emptyTypeTokens, $firstTagPtr - 1, $commentStartPtr, true);
if ($tokens[$firstTagPtr]['line'] !== $tokens[$prevPtr]['line'] + 2
&& strtolower($commentTagPtrContent) !== '@inheritdoc'
) {
$error = 'There must be exactly one blank line before tags';
$phpcsFile->addError($error, $firstTagPtr, 'MethodAnnotation');
}
}
}
/**
* Validates tag grouping format
*
* @param File $phpcsFile
* @param int $commentStartPtr
*/
public function validateTagGroupingFormat(File $phpcsFile, int $commentStartPtr): void
{
$tokens = $phpcsFile->getTokens();
$tagGroups = [];
$groupId = 0;
$paramGroupId = null;
foreach ($tokens[$commentStartPtr]['comment_tags'] as $position => $tag) {
if ($position > 0) {
$prevPtr = $phpcsFile->findPrevious(
T_DOC_COMMENT_STRING,
$tag - 1,
$tokens[$commentStartPtr]['comment_tags'][$position - 1]
);
if ($prevPtr === false) {
$prevPtr = $tokens[$commentStartPtr]['comment_tags'][$position - 1];
}
if ($tokens[$prevPtr]['line'] !== $tokens[$tag]['line'] - 1) {
$groupId++;
}
}
if (strtolower($tokens[$tag]['content']) === '@param') {
if ($paramGroupId !== null
&& $paramGroupId !== $groupId) {
$error = 'Parameter tags must be grouped together';
$phpcsFile->addError($error, $tag, 'MethodAnnotation');
}
if ($paramGroupId === null) {
$paramGroupId = $groupId;
}
}
$tagGroups[$groupId][] = $tag;
}
}
/**
* Validates tag aligning format
*
* @param File $phpcsFile
* @param int $commentStartPtr
*/
public function validateTagAligningFormat(File $phpcsFile, int $commentStartPtr): void
{
$tokens = $phpcsFile->getTokens();
$noAlignmentPositions = [];
$actualPositions = [];
$stackPtr = null;
foreach ($tokens[$commentStartPtr]['comment_tags'] as $tag) {
$content = $tokens[$tag]['content'];
if (preg_match('/^@/', $content) && ($tokens[$tag]['line'] === $tokens[$tag + 2]['line'])) {
$noAlignmentPositions[] = $tokens[$tag + 1]['column'] + 1;
$actualPositions[] = $tokens[$tag + 2]['column'];
$stackPtr = $stackPtr ?? $tag;
}
}
if (!$this->allTagsAligned($actualPositions)
&& !$this->noneTagsAligned($actualPositions, $noAlignmentPositions)) {
$phpcsFile->addError(
'Tags visual alignment must be consistent',
$stackPtr,
'MethodArguments'
);
}
}
/**
* Check whether all docblock params are aligned.
*
* @param array $actualPositions
* @return bool
*/
private function allTagsAligned(array $actualPositions): bool
{
return count(array_unique($actualPositions)) === 1;
}
/**
* Check whether all docblock params are not aligned.
*
* @param array $actualPositions
* @param array $noAlignmentPositions
* @return bool
*/
private function noneTagsAligned(array $actualPositions, array $noAlignmentPositions): bool
{
return $actualPositions === $noAlignmentPositions;
}
/**
* Validates extra newline before short description
*
* @param File $phpcsFile
* @param int $commentStartPtr
* @param int $commentEndPtr
* @param array $emptyTypeTokens
*/
private function validateNoExtraNewLineBeforeShortDescription(
File $phpcsFile,
int $commentStartPtr,
int $commentEndPtr,
array $emptyTypeTokens
): void {
$tokens = $phpcsFile->getTokens();
$prevPtr = $phpcsFile->findPrevious($emptyTypeTokens, $commentEndPtr - 1, $commentStartPtr, true);
if ($tokens[$prevPtr]['line'] < ($tokens[$commentEndPtr]['line'] - 1)) {
$error = 'Additional blank lines found at end of the annotation block';
$phpcsFile->addError($error, $commentEndPtr, 'MethodAnnotation');
}
}
/**
* Validates structure description format
*
* @param File $phpcsFile
* @param int $commentStartPtr
* @param int $shortPtr
* @param int $commentEndPtr
* @param array $emptyTypeTokens
*/
public function validateDescriptionFormatStructure(
File $phpcsFile,
int $commentStartPtr,
int $shortPtr,
int $commentEndPtr,
array $emptyTypeTokens
): void {
$tokens = $phpcsFile->getTokens();
if (isset($tokens[$commentStartPtr]['comment_tags'][0])
) {
$commentTagPtr = $tokens[$commentStartPtr]['comment_tags'][0];
$commentTagPtrContent = $tokens[$commentTagPtr]['content'];
if ($tokens[$shortPtr]['code'] !== T_DOC_COMMENT_STRING
&& strtolower($commentTagPtrContent) !== '@inheritdoc'
) {
$error = 'Missing short description';
$phpcsFile->addError($error, $commentStartPtr, 'MethodAnnotation');
} else {
$this->validateShortDescriptionFormat(
$phpcsFile,
(int)$shortPtr,
(int)$commentStartPtr,
(int)$commentEndPtr,
$emptyTypeTokens
);
}
} else {
$this->validateShortDescriptionFormat(
$phpcsFile,
(int)$shortPtr,
$commentStartPtr,
$commentEndPtr,
$emptyTypeTokens
);
}
}
}