Skip to content

Commit 48ff5f2

Browse files
committed
Improve test cases
1 parent 42bc067 commit 48ff5f2

6 files changed

+55
-15
lines changed

Diff for: Magento2/Tests/Html/HtmlClosingVoidTagsUnitTest.inc

+7
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@
2222
<hr/>
2323
<img src="" alt=""/>
2424
<input type="text" id="test_input"/>
25+
<input type="text"
26+
id="multi-line-input"
27+
placeholder="Alert should be on last line"
28+
/>
29+
<input type="text"
30+
id="multi-line-input2"
31+
placeholder="Alert should be on last line" />
2532
<link/>
2633
<meta/>
2734
<video>

Diff for: Magento2/Tests/Html/HtmlClosingVoidTagsUnitTest.inc.fixed

+7
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@
2222
<hr>
2323
<img src="" alt="">
2424
<input type="text" id="test_input">
25+
<input type="text"
26+
id="multi-line-input"
27+
placeholder="Alert should be on last line"
28+
/>
29+
<input type="text"
30+
id="multi-line-input2"
31+
placeholder="Alert should be on last line" />
2532
<link>
2633
<meta>
2734
<video>

Diff for: Magento2/Tests/Html/HtmlClosingVoidTagsUnitTest.php

+6-5
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public function getErrorList()
2323
public function getWarningList()
2424
{
2525
return [
26+
1 => 2,
2627
10 => 1,
2728
11 => 1,
2829
14 => 1,
@@ -32,13 +33,13 @@ public function getWarningList()
3233
22 => 1,
3334
23 => 1,
3435
24 => 1,
35-
25 => 1,
36-
26 => 1,
37-
28 => 1,
38-
29 => 1,
39-
31 => 1,
4036
32 => 1,
4137
33 => 1,
38+
35 => 1,
39+
36 => 1,
40+
38 => 1,
41+
39 => 1,
42+
40 => 1,
4243
];
4344
}
4445
}

Diff for: Magento2/Tests/Html/HtmlSelfClosingTagsUnitTest.1.inc

+12
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@
2222
<hr/>
2323
<img src="" alt=""/>
2424
<input type="text" id="test_input"/>
25+
<input type="text"
26+
id="multi-line-input"
27+
placeholder="Alert should be on last line"
28+
/>
29+
<input type="text"
30+
id="multi-line-input2"
31+
placeholder="Alert should be on last line" />
2532
<link/>
2633
<meta/>
2734
<video>
@@ -31,6 +38,11 @@
3138
<wbr/>
3239

3340
<label for="test_input"/>
41+
<label
42+
for="multi-line-input"
43+
/>
44+
<label
45+
for="multi-line-input2" />
3446
<style type="text/css"/>
3547
<div/>
3648
<span/>

Diff for: Magento2/Tests/Html/HtmlSelfClosingTagsUnitTest.1.inc.fixed

+12
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,13 @@
2222
<hr/>
2323
<img src="" alt=""/>
2424
<input type="text" id="test_input"/>
25+
<input type="text"
26+
id="multi-line-input"
27+
placeholder="Alert should be on last line"
28+
/>
29+
<input type="text"
30+
id="multi-line-input2"
31+
placeholder="Alert should be on last line" />
2532
<link/>
2633
<meta/>
2734
<video>
@@ -31,6 +38,11 @@
3138
<wbr/>
3239

3340
<label for="test_input"></label>
41+
<label
42+
for="multi-line-input"
43+
/>
44+
<label
45+
for="multi-line-input2" />
3446
<style type="text/css"></style>
3547
<div></div>
3648
<span></span>

Diff for: Magento2/Tests/Html/HtmlSelfClosingTagsUnitTest.php

+11-10
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,18 @@ class HtmlSelfClosingTagsUnitTest extends AbstractSniffUnitTest
1515
public function getErrorList()
1616
{
1717
return [
18-
33 => 1,
19-
34 => 1,
20-
35 => 1,
21-
36 => 1,
22-
37 => 1,
23-
38 => 1,
24-
39 => 1,
18+
1 => 2,
2519
40 => 1,
26-
41 => 1,
27-
42 => 1,
28-
43 => 1,
20+
46 => 1,
21+
47 => 1,
22+
48 => 1,
23+
49 => 1,
24+
50 => 1,
25+
51 => 1,
26+
52 => 1,
27+
53 => 1,
28+
54 => 1,
29+
55 => 1,
2930
];
3031
}
3132

0 commit comments

Comments
 (0)