Skip to content

Commit c5dbf03

Browse files
Merge pull request #70 from magento-commerce/imported-eliseacornejo-magento-coding-standard-279
[Imported] AC-1307: PHP Syntax errors in xml files
2 parents 4e23b97 + 5052feb commit c5dbf03

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

Magento2/ruleset.xml

+20
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,23 @@
1414
<severity>10</severity>
1515
<type>error</type>
1616
<exclude-pattern>*\.phtml$</exclude-pattern>
17+
<exclude-pattern>*\.xml$</exclude-pattern>
1718
</rule>
1819
<rule ref="Generic.PHP.DeprecatedFunctions">
1920
<severity>10</severity>
2021
<type>error</type>
22+
<exclude-pattern>*\.xml$</exclude-pattern>
2123
</rule>
2224
<rule ref="Generic.PHP.NoSilencedErrors">
2325
<severity>10</severity>
2426
<type>error</type>
2527
<exclude-pattern>*/lib/*</exclude-pattern>
28+
<exclude-pattern>*\.xml$</exclude-pattern>
2629
</rule>
2730
<rule ref="Generic.PHP.Syntax">
2831
<severity>10</severity>
2932
<type>error</type>
33+
<exclude-pattern>*\.xml$</exclude-pattern>
3034
</rule>
3135
<rule ref="Magento2.Classes.DiscouragedDependencies">
3236
<severity>10</severity>
@@ -48,14 +52,17 @@
4852
<rule ref="Magento2.PHP.FinalImplementation">
4953
<severity>10</severity>
5054
<type>error</type>
55+
<exclude-pattern>*\.xml$</exclude-pattern>
5156
</rule>
5257
<rule ref="Magento2.PHP.Goto">
5358
<severity>10</severity>
5459
<type>error</type>
60+
<exclude-pattern>*\.xml$</exclude-pattern>
5561
</rule>
5662
<rule ref="Magento2.PHP.ReturnValueCheck">
5763
<severity>10</severity>
5864
<type>error</type>
65+
<exclude-pattern>*\.xml$</exclude-pattern>
5966
</rule>
6067
<rule ref="Magento2.Security.IncludeFile">
6168
<severity>10</severity>
@@ -104,6 +111,7 @@
104111
<rule ref="Squiz.PHP.Eval">
105112
<severity>10</severity>
106113
<type>error</type>
114+
<exclude-pattern>*\.xml$</exclude-pattern>
107115
</rule>
108116
<rule ref="Magento2.Legacy.AbstractBlock">
109117
<severity>10</severity>
@@ -161,6 +169,7 @@
161169
<rule ref="Squiz.PHP.NonExecutableCode">
162170
<severity>9</severity>
163171
<type>warning</type>
172+
<exclude-pattern>*\.xml$</exclude-pattern>
164173
</rule>
165174
<rule ref="Magento2.Html.HtmlBinding">
166175
<severity>9</severity>
@@ -232,6 +241,7 @@
232241
<rule ref="Magento2.PHP.ShortEchoSyntax">
233242
<severity>8</severity>
234243
<type>warning</type>
244+
<exclude-pattern>*\.xml$</exclude-pattern>
235245
</rule>
236246
<rule ref="Magento2.Templates.ThisInTemplate">
237247
<include-pattern>*\.phtml$</include-pattern>
@@ -325,10 +335,12 @@
325335
<exclude-pattern>*/Test/*</exclude-pattern>
326336
<exclude-pattern>*Test.php</exclude-pattern>
327337
<exclude-pattern>*/tests/*</exclude-pattern>
338+
<exclude-pattern>*\.xml$</exclude-pattern>
328339
</rule>
329340
<rule ref="Magento2.PHP.Var">
330341
<severity>7</severity>
331342
<type>warning</type>
343+
<exclude-pattern>*\.xml$</exclude-pattern>
332344
</rule>
333345
<rule ref="Magento2.Performance.ForeachArrayMerge">
334346
<severity>7</severity>
@@ -368,6 +380,7 @@
368380
<exclude-pattern>*/Test/*</exclude-pattern>
369381
<exclude-pattern>*Test.php</exclude-pattern>
370382
<exclude-pattern>*/tests/*</exclude-pattern>
383+
<exclude-pattern>*\.xml$</exclude-pattern>
371384
</rule>
372385
<rule ref="Squiz.Scope.MemberVarScope">
373386
<severity>7</severity>
@@ -406,10 +419,12 @@
406419
<rule ref="Generic.PHP.LowerCaseConstant">
407420
<severity>6</severity>
408421
<type>warning</type>
422+
<exclude-pattern>*\.xml$</exclude-pattern>
409423
</rule>
410424
<rule ref="Generic.PHP.LowerCaseKeyword">
411425
<severity>6</severity>
412426
<type>warning</type>
427+
<exclude-pattern>*\.xml$</exclude-pattern>
413428
</rule>
414429
<rule ref="Generic.WhiteSpace.DisallowTabIndent">
415430
<severity>6</severity>
@@ -640,6 +655,7 @@
640655
</properties>
641656
<severity>5</severity>
642657
<type>warning</type>
658+
<exclude-pattern>*\.xml$</exclude-pattern>
643659
</rule>
644660
<rule ref="Magento2.Annotation">
645661
<severity>5</severity>
@@ -651,10 +667,14 @@
651667
<rule ref="Magento2.Legacy.CopyrightAnotherExtensionsFiles">
652668
<severity>5</severity>
653669
<type>warning</type>
670+
<exclude-pattern>*\.php$</exclude-pattern>
671+
<exclude-pattern>*\.phtml$</exclude-pattern>
654672
</rule>
655673
<rule ref="Magento2.Legacy.Copyright">
656674
<severity>5</severity>
657675
<type>warning</type>
676+
<include-pattern>*\.php$</include-pattern>
677+
<include-pattern>*\.phtml$</include-pattern>
658678
</rule>
659679
<rule ref="Internal.NoCodeFound">
660680
<severity>0</severity>

0 commit comments

Comments
 (0)