Add missing type-cast from SimpleXMLElement

fredden · fredden · commit ef3ab208bfdb · 2024-09-27T17:06:57.000+01:00
diff --git a/Magento2/Sniffs/Legacy/WidgetXMLSniff.php b/Magento2/Sniffs/Legacy/WidgetXMLSniff.php
@@ -53,7 +53,7 @@ public function process(File $phpcsFile, $stackPtr)
             if (!property_exists($element->attributes(), 'type')) {
                 continue;
             }
-            $type = $element['type'];
+            $type = (string) $element['type'];
             if (preg_match('/\//', $type)) {
                 $phpcsFile->addError(
                     "Factory name detected: {$type}.",

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function process(File $phpcsFile, $stackPtr)`
`53`	`53`	`if (!property_exists($element->attributes(), 'type')) {`
`54`	`54`	`continue;`
`55`	`55`	`}`
`56`		`- $type = $element['type'];`
	`56`	`+ $type = (string) $element['type'];`
`57`	`57`	`if (preg_match('/\//', $type)) {`
`58`	`58`	`$phpcsFile->addError(`
`59`	`59`	`"Factory name detected: {$type}.",`