Merge pull request #352 from magento-gl/MFTF-4.5.0-RC

ACQE-5822 :  MFTF 4.5.0 Release Checklist.

Author: KevinBKozan

Diff for: .github/.metadata.json

@@ -1,26 +1,27 @@
 {
-    "templateVersion": "0.1",
+    "templateVersion": "0.2",
     "product": {
         "name": "Magento2 Functional Testing Framework (MFTF)",
         "description": "MFTF is a framework to write and execute UI Functional tests for Magento 2 projects"
     },
     "contacts": {
         "team": {
-            "name": "Magento Quality Engineering / Pangolin",
+            "name": "Adobe Commerce Quality Engineering / Pangolin",
             "DL": "GRP-Pangolin",
             "slackChannel": "mftf"
         }
     },
     "ticketTracker": {
         "functionalJiraQueue": {
-            "projectKey": "MQE",
+            "projectKey": "ACQE",
             "component": "Framework - MFTF"
         },
         "securityJiraQueue": {
             "projectKey": "MAGREQ",
             "component": "Test Infrastructure"
         }
     },
+    "productionCodeBranches": ["master"],
     "staticScan": {
         "enable": true,
         "frequency": "monthly",

Diff for: CHANGELOG.md

@@ -1,5 +1,14 @@
 Magento Functional Testing Framework Changelog
 ================================================
+4.5.0
+---------
+### Enhancements
+* Increase browser resolution to 1920x1080.
+* Add metadata to ACQE Repositories.
+* Add magento admin password to credentials example.
+
+### Fixes
+* Fixed test failure while running any test suite with an argument.
 
 4.4.2
 ---------

Diff for: composer.json

@@ -2,7 +2,7 @@
     "name": "magento/magento2-functional-testing-framework",
     "description": "Magento2 Functional Testing Framework",
     "type": "library",
-    "version": "4.4.2",
+    "version": "4.5.0",
     "license": "AGPL-3.0",
     "keywords": ["magento", "automation", "functional", "testing"],
     "config": {

Diff for: composer.lock

@@ -1,4 +1,5 @@
 magento/tfa/OTP_SHARED_SECRET
+magento/MAGENTO_ADMIN_PASSWORD
 
 #magento/carriers_fedex_account=
 #magento/carriers_fedex_meter_number=

Diff for: etc/config/.credentials.example

@@ -24,6 +24,8 @@ SELENIUM_CLOSE_ALL_SESSIONS=true
 
 #*** Browser for running tests, default chrome. Uncomment and change if you want to run tests on another browser (ex. firefox).
 BROWSER=chrome
+WINDOW_WIDTH=1920
+WINDOW_HEIGHT=1080
 
 #*** Uncomment and set host & port if your dev environment needs different value other than MAGENTO_BASE_URL for Rest API Requests ***#
 #MAGENTO_RESTAPI_SERVER_HOST=restapi.magento.com

Diff for: etc/config/.env.example

@@ -24,7 +24,7 @@ modules:
             backend_name: "%MAGENTO_BACKEND_NAME%"
             browser: 'chrome'
             restart: true
-            window_size: 1280x1024
+            window_size: 1920x1080
             username: "%MAGENTO_ADMIN_USERNAME%"
             password: "%MAGENTO_ADMIN_PASSWORD%"
             pageload_timeout: "%WAIT_TIMEOUT%"
@@ -38,4 +38,4 @@ modules:
             capabilities:
                 unhandledPromptBehavior: "ignore"
                 chromeOptions:
-                    args: ["--no-sandbox", "--window-size=1280,1024", "--disable-extensions", "--enable-automation", "--disable-gpu", "--enable-Passthrough", "--disable-dev-shm-usage", "--ignore-certificate-errors", "--disable-component-update", "--disable-features=OptimizationHints","--disable-background-networking","--disable-domain-reliability","--disable-breakpad"]
+                    args: ["--no-sandbox", "--window-size=1920,1080", "--disable-extensions", "--enable-automation", "--disable-gpu", "--enable-Passthrough", "--disable-dev-shm-usage", "--ignore-certificate-errors", "--disable-component-update", "--disable-features=OptimizationHints","--disable-background-networking","--disable-domain-reliability","--disable-breakpad"]

Diff for: etc/config/functional.suite.dist.yml

@@ -231,9 +231,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 $testManifest->createTestGroups($configNumber);
             }
 
+            SuiteGenerator::getInstance()->generateAllSuites($testManifest);
+
             $testManifest->generate();
 
-            SuiteGenerator::getInstance()->generateAllSuites($testManifest);
+            SuiteGenerator::getInstance()->generateTestgroupmembership($testManifest);
         } catch (\Exception $e) {
             if (!empty(GenerationErrorHandler::getInstance()->getAllErrors())) {
                 GenerationErrorHandler::getInstance()->printErrorSummary();

Diff for: src/Magento/FunctionalTestingFramework/Console/GenerateTestsCommand.php

@@ -95,7 +95,6 @@ public static function getInstance(): SuiteGenerator
      */
     public function generateAllSuites($testManifest)
     {
-        $this->generateTestgroupmembership($testManifest);
         $suites = $testManifest->getSuiteConfig();
 
         foreach ($suites as $suiteName => $suiteContent) {