Skip to content

Commit 05c9107

Browse files
committed
2490: Refactor NewModuleFileGroup to optimize index usage
Reused `FileBasedIndex` instance to enhance readability and performance by avoiding redundant calls. Also, fixed import order to follow code style conventions.
1 parent fdee0ec commit 05c9107

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/main/java/com/magento/idea/magento2plugin/actions/groups/NewModuleFileGroup.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@
1919
import com.magento.idea.magento2plugin.actions.generation.util.IsClickedDirectoryInsideProject;
2020
import com.magento.idea.magento2plugin.project.Settings;
2121
import com.magento.idea.magento2plugin.stubs.indexes.ModuleNameIndex;
22-
import org.jetbrains.annotations.Nullable;
23-
2422
import java.util.Collection;
23+
import org.jetbrains.annotations.Nullable;
2524

2625
public class NewModuleFileGroup extends NonTrivialActionGroup {
2726

@@ -81,8 +80,9 @@ public void update(final AnActionEvent event) {
8180
final VirtualFile psiDirectoryVirtualFile
8281
) {
8382
String moduleName = null;
84-
for (final String entry : FileBasedIndex.getInstance().getAllKeys(ModuleNameIndex.KEY, project)) {
85-
final Collection<VirtualFile> moduleVfs = FileBasedIndex.getInstance().getContainingFiles(
83+
final FileBasedIndex index = FileBasedIndex.getInstance();
84+
for (final String entry : index.getAllKeys(ModuleNameIndex.KEY, project)) {
85+
final Collection<VirtualFile> moduleVfs = index.getContainingFiles(
8686
ModuleNameIndex.KEY, entry, GlobalSearchScope.projectScope(project)
8787
);
8888

0 commit comments

Comments
 (0)