Skip to content

Commit 843be9b

Browse files
author
Oleksii Korshenko
committed
MAGETWO-67680: Replace Zend_Mail (ZF1) with Zend\Mail (ZF2) #8608
- removed methods getBodyHtml() and getBodyText(). Use method getBody()
1 parent 13b2c41 commit 843be9b

File tree

4 files changed

+24
-55
lines changed

4 files changed

+24
-55
lines changed

app/code/Magento/Newsletter/Model/Queue/TransportBuilder.php

+19-7
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace Magento\Newsletter\Model\Queue;
77

88
use Magento\Email\Model\AbstractTemplate;
9+
use Magento\Framework\Exception\LocalizedException;
910

1011
class TransportBuilder extends \Magento\Framework\Mail\Template\TransportBuilder
1112
{
@@ -48,13 +49,24 @@ protected function prepareMessage()
4849
$template = $this->getTemplate()->setData($this->templateData);
4950
$this->setTemplateFilter($template);
5051

51-
$this->message->setMessageType(
52-
\Magento\Framework\Mail\MessageInterface::TYPE_HTML
53-
)->setBody(
54-
$template->getProcessedTemplate($this->templateVars)
55-
)->setSubject(
56-
$template->getSubject()
57-
);
52+
$body = $template->getProcessedTemplate($this->templateVars);
53+
switch ($template->getType()) {
54+
case \Magento\Framework\Mail\MessageInterface::TYPE_TEXT:
55+
$this->message->setBodyText($body);
56+
break;
57+
58+
case \Magento\Framework\Mail\MessageInterface::TYPE_HTML:
59+
$this->message->setBodyHtml($body);
60+
break;
61+
62+
default;
63+
throw new LocalizedException(
64+
__('Unknown template type')
65+
);
66+
break;
67+
}
68+
69+
$this->message->setSubject($template->getSubject());
5870

5971
return $this;
6072
}

lib/internal/Magento/Framework/Mail/MailMessageInterface.php

-10
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,6 @@ public function setBodyHtml($html);
2424
*/
2525
public function setBodyText($text);
2626

27-
/**
28-
* @return string
29-
*/
30-
public function getBodyText();
31-
32-
/**
33-
* @return string
34-
*/
35-
public function getBodyHtml();
36-
3727
/**
3828
* Get message source code
3929
*

lib/internal/Magento/Framework/Mail/Message.php

-33
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
*/
88
namespace Magento\Framework\Mail;
99

10-
use Magento\Framework\Exception\LocalizedException;
1110
use Zend\Mime\Mime;
1211
use Zend\Mime\Part;
1312

@@ -43,8 +42,6 @@ public function __construct($charset = 'utf-8')
4342
* {@inheritdoc}
4443
*
4544
* @deprecated
46-
* @see \Magento\Framework\Mail\Message::getBodyText
47-
* @see \Magento\Framework\Mail\Message::getBodyHtml
4845
* @see \Magento\Framework\Mail\Message::setBodyText
4946
* @see \Magento\Framework\Mail\Message::setBodyHtml
5047
*/
@@ -90,10 +87,6 @@ public function getSubject()
9087

9188
/**
9289
* {@inheritdoc}
93-
*
94-
* @deprecated
95-
* @see \Magento\Framework\Mail\Message::getBodyText
96-
* @see \Magento\Framework\Mail\Message::getBodyHtml
9790
*/
9891
public function getBody()
9992
{
@@ -189,30 +182,4 @@ public function setBodyText($text)
189182
$this->setMessageType(self::TYPE_TEXT);
190183
return $this->setBody($text);
191184
}
192-
193-
/**
194-
* {@inheritdoc}
195-
*/
196-
public function getBodyText()
197-
{
198-
if ($this->messageType != self::TYPE_TEXT) {
199-
throw new LocalizedException(
200-
__('Text message body is not set')
201-
);
202-
}
203-
return $this->getBody();
204-
}
205-
206-
/**
207-
* {@inheritdoc}
208-
*/
209-
public function getBodyHtml()
210-
{
211-
if ($this->messageType != self::TYPE_HTML) {
212-
throw new LocalizedException(
213-
__('HTML message body is not set')
214-
);
215-
}
216-
return $this->getBody();
217-
}
218185
}

lib/internal/Magento/Framework/Mail/MessageInterface.php

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,13 @@ interface MessageInterface
1616
{
1717
/**
1818
* Types of message
19+
* @deprecated
1920
*/
2021
const TYPE_TEXT = 'text/plain';
2122

23+
/**
24+
* @deprecated
25+
*/
2226
const TYPE_HTML = 'text/html';
2327

2428
/**
@@ -51,11 +55,7 @@ public function setBody($body);
5155
/**
5256
* Get message body
5357
*
54-
* @return mixed
55-
*
56-
* @deprecated
57-
* @see \Magento\Framework\Mail\MailMessageInterface::getBodyHtml
58-
* @see \Magento\Framework\Mail\MailMessageInterface::getBodyText()
58+
* @return string
5959
*/
6060
public function getBody();
6161

0 commit comments

Comments
 (0)