AC-8753: Coupon quantity generation checks

   * Validation and renaming of variables and text

Author: faraz-gl

app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Generate.php

@@ -61,9 +61,9 @@ class Generate extends Quote implements HttpPostActionInterface
     private ScopeConfigInterface $scopeConfig;
 
     /**
-     * Handle coupon quantity system name
+     * Coupon quantity limit config path
      */
-    private const XML_COUPON_QUANTITY = 'promo/auto_generated_coupon_codes/quantity';
+    private const XML_CONFIG_COUPON_QUANTITY_LIMIT = 'promo/auto_generated_coupon_codes/quantity_limit';
 
     /**
      * Generate constructor.
@@ -163,13 +163,14 @@ public function execute(): void
 
                 $data['quantity'] = $data['qty'] ?? null;
                 $couponQuantity = (int)$this->scopeConfig->getValue(
-                    self::XML_COUPON_QUANTITY,
+                    self::XML_CONFIG_COUPON_QUANTITY_LIMIT,
                     ScopeInterface::SCOPE_STORE
                 );
-                if ($data['quantity'] && $couponQuantity && $data['quantity'] > $couponQuantity) {
+                // @codingStandardsIgnoreStart
+                if ($data['quantity'] && $data['quantity'] > 0 && $couponQuantity && $data['quantity'] > $couponQuantity) {
                     $this->messageManager->addErrorMessage(
                         __(
-                            'Coupon qty should be less than or equal to the coupon qty in the store configuration.'
+                            'Coupon quantity should be less than or equal to the coupon quantity in the store configuration.'
                         )
                     );
                 } else {

app/code/Magento/SalesRule/Test/Unit/Controller/Adminhtml/Promo/Quote/GenerateTest.php

@@ -38,11 +38,11 @@
  */
 class GenerateTest extends TestCase
 {
-    /** @const XML_COUPON_QUANTITY_TEST */
-    private const XML_COUPON_QUANTITY_TEST = 'promo/auto_generated_coupon_codes/quantity';
+    /** @const XML_COUPON_QUANTITY_LIMIT_PATH_TEST */
+    private const XML_COUPON_QUANTITY_LIMIT_PATH_TEST = 'promo/auto_generated_coupon_codes/quantity_limit';
 
-    /** @const XML_COUPON_QUANTITY_TEST_VALUE */
-    private const XML_COUPON_QUANTITY_TEST_VALUE = 250000;
+    /** @const XML_COUPON_QUANTITY_LIMIT_VALUE_TEST */
+    private const XML_COUPON_QUANTITY_LIMIT_VALUE_TEST = 250000;
 
     /**
      * @var array
@@ -410,8 +410,8 @@ public function testExecuteWithInvalidCouponQuantity()
         $this->scopeConfigMock
             ->expects($this->once())
             ->method('getValue')
-            ->with(self::XML_COUPON_QUANTITY_TEST)
-            ->willReturn(self::XML_COUPON_QUANTITY_TEST_VALUE);
+            ->with(self::XML_COUPON_QUANTITY_LIMIT_PATH_TEST)
+            ->willReturn(self::XML_COUPON_QUANTITY_LIMIT_VALUE_TEST);
         $this->getCouponCodeLength->expects($this->once())
             ->method('fetchCouponCodeLength')
             ->willReturn(10);

app/code/Magento/SalesRule/etc/adminhtml/system.xml

@@ -19,8 +19,8 @@
                     <comment>Excluding prefix, suffix and separators.</comment>
                     <frontend_class>validate-digits</frontend_class>
                 </field>
-                <field id="quantity" translate="label comment" type="text" sortOrder="20" showInDefault="1" canRestore="1">
-                    <label>Code Quantity</label>
+                <field id="quantity_limit" translate="label comment" type="text" sortOrder="20" showInDefault="1" canRestore="1">
+                    <label>Code Quantity Limit</label>
                     <comment>For better performance max value allowed is 250,000.</comment>
                     <frontend_class>required-entry validate-number-range number-range-1-250000</frontend_class>
                 </field>

app/code/Magento/SalesRule/i18n/en_US.csv

@@ -169,4 +169,4 @@ Apply,Apply
 "Sorry, something went wrong while triggering recollect totals for affected quotes. Please see log for details.","Sorry, something went wrong while triggering recollect totals for affected quotes. Please see log for details."
 "When coupon quantity exceeds %1, the coupon code length must be minimum %2", "When coupon quantity exceeds %1, the coupon code length must be minimum %2"
 "Discount amount is distributed among subtotal and shipping amount. Cases when multiple discounts applied to shipping amount are not supported. The option is going to be removed in future releases.ly","Discount amount is distributed among subtotal and shipping amount. Cases when multiple discounts applied to shipping amount are not supported. The option is going to be removed in future releases."
-"Coupon qty should be less than or equal to the coupon qty in the store configuration.","Coupon qty should be less than or equal to the coupon qty in the store configuration."
+"Coupon quantity should be less than or equal to the coupon quantity in the store configuration.","Coupon quantity should be less than or equal to the coupon quantity in the store configuration."