AC-8753: Coupon quantity generation checks

   * Disable option for coupon quantities added

Author: faraz-gl

app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Generate.php

@@ -166,15 +166,15 @@ public function execute(): void
                     self::XML_CONFIG_COUPON_QUANTITY_LIMIT,
                     ScopeInterface::SCOPE_STORE
                 );
-                if ($data['quantity'] > 0 && $data['quantity'] <= $couponQuantityLimit) {
+                // @codingStandardsIgnoreStart
+                if ($data['quantity'] > 0 && ($data['quantity'] <= $couponQuantityLimit || $couponQuantityLimit === 0)) {
                     $couponSpec = $this->generationSpecFactory->create(['data' => $data]);
 
                     $this->messagePublisher->publish('sales_rule.codegenerator', $couponSpec);
                     $this->messageManager->addSuccessMessage(
-                        __('Message is added to queue, wait to get your coupons soon')
+                        __('Message is added to queue, wait to get your coupons soon.')
                     );
                 } else {
-                    // @codingStandardsIgnoreStart
                     $this->messageManager->addErrorMessage(
                         __(
                             'Coupon quantity should be less than or equal to the coupon quantity in the store configuration.'

app/code/Magento/SalesRule/Test/Unit/Controller/Adminhtml/Promo/Quote/GenerateTest.php

@@ -44,6 +44,9 @@ class GenerateTest extends TestCase
     /** @const XML_COUPON_QUANTITY_LIMIT_VALUE_TEST */
     private const XML_COUPON_QUANTITY_LIMIT_VALUE_TEST = 250000;
 
+    /** @const XML_COUPON_QUANTITY_LIMIT_DISABLE_VALUE_TEST */
+    private const XML_COUPON_QUANTITY_LIMIT_DISABLE_VALUE_TEST = 0;
+
     /**
      * @var array
      */
@@ -446,4 +449,79 @@ public function testExecuteWithInvalidCouponQuantity()
             ->willReturn(__('Coupon qty should be less than or equal to the coupon qty in the store configuration.'));
         $this->model->execute();
     }
+
+    /**
+     * @covers \Magento\SalesRule\Controller\Adminhtml\Promo\Quote::execute
+     */
+    public function testExecuteWithDisableCouponQuantity()
+    {
+        $helperData = $this->getMockBuilder(Data::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->objectManagerMock->expects($this->any())
+            ->method('get')
+            ->with(Data::class)
+            ->willReturn($helperData);
+        $this->requestMock->expects($this->once())
+            ->method('isAjax')
+            ->willReturn(true);
+        $ruleMock = $this->getMockBuilder(Rule::class)
+            ->addMethods(['getCouponType'])
+            ->onlyMethods(['getId'])
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->registryMock->expects($this->once())
+            ->method('registry')
+            ->willReturn($ruleMock);
+        $ruleMock->expects($this->once())
+            ->method('getId')
+            ->willReturn(1);
+        $ruleMock->expects($this->once())
+            ->method('getCouponType')
+            ->willReturn(Rule::COUPON_TYPE_AUTO);
+        $this->requestMock->expects($this->once())
+            ->method('getParams')
+            ->willReturn($this->requestMockDataWithInvalidCouponQuantity);
+        $this->scopeConfigMock
+            ->expects($this->once())
+            ->method('getValue')
+            ->with(self::XML_COUPON_QUANTITY_LIMIT_PATH_TEST)
+            ->willReturn(self::XML_COUPON_QUANTITY_LIMIT_DISABLE_VALUE_TEST);
+        $this->requestMockDataWithInvalidCouponQuantity['quantity'] = $this->requestMockDataWithInvalidCouponQuantity['qty'] ?? 0;
+        $this->couponGenerationSpec->expects($this->any())
+            ->method('create')
+            ->with(['data' => $this->requestMockDataWithInvalidCouponQuantity])
+            ->willReturn(['some_data', 'some_data_2']);
+        $this->getCouponCodeLength->expects($this->once())
+            ->method('fetchCouponCodeLength')
+            ->willReturn(10);
+        $this->messageManager->expects($this->any())
+            ->method('addSuccessMessage');
+        $this->responseMock->expects($this->once())
+            ->method('representJson')
+            ->with();
+        $helperData->expects($this->once())
+            ->method('jsonEncode')
+            ->with([
+                'messages' => __('%1 coupon(s) have been generated.', 2)
+            ]);
+        $layout = $this->getMockBuilder(Layout::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->view->expects($this->any())
+            ->method('getLayout')
+            ->willReturn($layout);
+        $messageBlock = $this->getMockBuilder(Messages::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $layout->expects($this->once())
+            ->method('initMessages');
+        $layout->expects($this->once())
+            ->method('getMessagesBlock')
+            ->willReturn($messageBlock);
+        $messageBlock->expects($this->once())
+            ->method('getGroupedHtml')
+            ->willReturn(__('%1 coupon(s) have been generated.', 2));
+        $this->model->execute();
+    }
 }

app/code/Magento/SalesRule/etc/adminhtml/system.xml

@@ -21,8 +21,8 @@
                 </field>
                 <field id="quantity_limit" translate="label comment" type="text" sortOrder="20" showInDefault="1" canRestore="1">
                     <label>Code Quantity Limit</label>
-                    <comment>For better performance max value allowed is 250,000.</comment>
-                    <frontend_class>required-entry validate-number-range number-range-1-250000</frontend_class>
+                    <comment>For better performance max value allowed is 250,000. Set 0 to disable it.</comment>
+                    <frontend_class>required-entry validate-number-range number-range-0-250000</frontend_class>
                 </field>
                 <field id="format" translate="label" type="select" sortOrder="30" showInDefault="1" canRestore="1">
                     <label>Code Format</label>

app/code/Magento/SalesRule/i18n/en_US.csv

@@ -171,4 +171,4 @@ Apply,Apply
 "Discount amount is distributed among subtotal and shipping amount. Cases when multiple discounts applied to shipping amount are not supported. The option is going to be removed in future releases.ly","Discount amount is distributed among subtotal and shipping amount. Cases when multiple discounts applied to shipping amount are not supported. The option is going to be removed in future releases."
 "Coupon quantity should be less than or equal to the coupon quantity in the store configuration.","Coupon quantity should be less than or equal to the coupon quantity in the store configuration."
 "Code Quantity Limit","Code Quantity Limit"
-"For better performance max value allowed is 250,000.","For better performance max value allowed is 250,000."
+"For better performance max value allowed is 250,000. Set 0 to disable it.","For better performance max value allowed is 250,000. Set 0 to disable it."