Skip to content

As a developer, I am confused about the current state of the Magento license. #39493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damienwebdev opened this issue Dec 18, 2024 · 13 comments
Labels
Issue: ready for confirmation Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@damienwebdev
Copy link
Member

damienwebdev commented Dec 18, 2024

{}Issue description{}:

We are receiving escalations from the community that we there are still Magento Open Source where Adobe confidential copyright notice is being used instead of s reduced open source form of copyright. Please see examples below:

In scope of this ticket we need to find all the files under the Magento Open Source repository [https://github.com/magento/magento2] where we still continue using confidential notice and remove it.  

{}Acceptance criteria{}:

  • There are no any files in the [https://github.com/magento/magento2] repo which have [Adobe Confidential copyright.pdf]notice in it and the reduced form of Adobe copyright is being used instead [Reduced form Copyright.pdf>
  • Files with old Magento copyright should remain unchanged. 
@damienwebdev damienwebdev added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Dec 18, 2024
Copy link

m2-assistant bot commented Dec 18, 2024

Hi @damienwebdev. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@rhoerr
Copy link

rhoerr commented Dec 18, 2024

Related:
#37631 (comment)
#39099 (comment)

@ihor-sviziev
Copy link
Contributor

@sidolov, could you please reply? Will all these Adobe notices be removed from the Magento Open Source version?

@chernenm
Copy link

hi @ihor-sviziev, @damienwebdev, this notice was used by our Adobe internal team member by mistake, we will remove it asap.

@hostep
Copy link
Contributor

hostep commented Dec 18, 2024

@chernenm: it would help a lot if the new copyright format is being fully validated by your coding standards tool, right now it only checks for the first line and doesn't care what other lines follow. If this can be checked fully, this problem wouldn't have happened probably.
Also having some documentation being published about it for the non-Adobe contributors here on github would help significantly for people who don't know yet about this new format.

@engcom-Bravo
Copy link
Contributor

Hi @damienwebdev,

Thanks for your reporting and collaboration.

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions.

Hence moving this issue to ON HOLD.

Thank you!

@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to On Hold in Issue Confirmation and Triage Board Dec 19, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Dec 20, 2024
@github-jira-sync-bot github-jira-sync-bot added Progress: dev in progress Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Dec 23, 2024
@hostep
Copy link
Contributor

hostep commented Dec 30, 2024

@engcom-Bravo, @chernenm: why did this issue got closed automatically without any comments explaining why exactly?

Update: probably because of 1c6bb3c & 478b961? It's not a full fix however, just a cleanup action, if this isn't being guarded by automation, this has a chance of happening again...

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Dec 31, 2024

Hello,

The issue got fixed in the https://github.com/search?q=repo%3Amagento%2Fmagento2+public_copyright&type=commits

Thank you!

@ihor-sviziev
Copy link
Contributor

@engcom-Charlie @engcom-Hotel,
I see that the issue appeared again in 5 files https://github.com/search?q=repo%3Amagento%2Fmagento2%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code
Could you please implement a fix that makes sure no such notice appear in the public repo?

@adamwaclawczyk
Copy link

It's now in 54 files https://github.com/search?q=repo%3Amagento%2Fmagento2%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Apr 10, 2025

@engcom-Bravo @engcom-Charlie @engcom-Hotel could you please make sure it's fixed and all needed internal processes / automations are aligned with it?

@ihor-sviziev ihor-sviziev reopened this Apr 10, 2025
@hostep
Copy link
Contributor

hostep commented Apr 10, 2025

Detecting this automatically would be the ideal solution, so it would be appreciated if magento/magento-coding-standard#492 could be tackled as well at the same time as the cleanup.

Also this query is better, to search in all repositories belonging to magento: https://github.com/search?q=org%3Amagento%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code, because this wrong copyright is used in plenty of other magento repositories.

@engcom-Charlie
Copy link
Contributor

Thank you @hostep @ihor-sviziev @damienwebdev @adamwaclawczyk for you input.

Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Ready for Confirmation
Development

No branches or pull requests

9 participants