-
Notifications
You must be signed in to change notification settings - Fork 9.4k
As a developer, I am confused about the current state of the Magento license. #39493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @damienwebdev. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Related: |
@sidolov, could you please reply? Will all these Adobe notices be removed from the Magento Open Source version? |
hi @ihor-sviziev, @damienwebdev, this notice was used by our Adobe internal team member by mistake, we will remove it asap. |
@chernenm: it would help a lot if the new copyright format is being fully validated by your coding standards tool, right now it only checks for the first line and doesn't care what other lines follow. If this can be checked fully, this problem wouldn't have happened probably. |
Hi @damienwebdev, Thanks for your reporting and collaboration. Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions. Hence moving this issue to Thank you! |
@engcom-Bravo, @chernenm: why did this issue got closed automatically without any comments explaining why exactly? Update: probably because of 1c6bb3c & 478b961? It's not a full fix however, just a cleanup action, if this isn't being guarded by automation, this has a chance of happening again... |
Hello, The issue got fixed in the https://github.com/search?q=repo%3Amagento%2Fmagento2+public_copyright&type=commits Thank you! |
@engcom-Charlie @engcom-Hotel, |
@engcom-Bravo @engcom-Charlie @engcom-Hotel could you please make sure it's fixed and all needed internal processes / automations are aligned with it? |
Detecting this automatically would be the ideal solution, so it would be appreciated if magento/magento-coding-standard#492 could be tackled as well at the same time as the cleanup. Also this query is better, to search in all repositories belonging to |
Thank you @hostep @ihor-sviziev @damienwebdev @adamwaclawczyk for you input. Adobe Commerce Engineering team started working on this issue. We will reach out to you if we need more information and you will get notified once the issue is fixed. Please leave comments for any further questions. Thank you! |
{}Issue description{}:
We are receiving escalations from the community that we there are still Magento Open Source where Adobe confidential copyright notice is being used instead of s reduced open source form of copyright. Please see examples below:
https://github.com/search?q=repo%3Amagento%2Fmagento2%20All%20information%20contained%20herein%20is%2C%20and%20remains&type=code
In scope of this ticket we need to find all the files under the Magento Open Source repository [https://github.com/magento/magento2] where we still continue using confidential notice and remove it.
{}Acceptance criteria{}:
The text was updated successfully, but these errors were encountered: