SalesRule - Apply rules fails when it shouldn't

[Nuranto]

Preconditions and environment

• Magento version 2.4.7-p3

Steps to reproduce

1. Create a sales rule with :
   • Coupon code = test
   • No limitation
   • No conditions
   • Action = Fixed amount for whole cart, 1€ discount
   • Apply to Shipping Amount = yes
   • Product condition = name equals to "any_text_that_is_not_a_product_name"
2. Apply 'test' coupon to a frontend cart with a shipping amount

Expected result

Coupon is applied, 1€ discount applied on shipping amount

Actual result

Cannot apply coupon

Additional information

src/vendor/magento/module-sales-rule/Model/RulesApplier.php::applyRules manage rules having apply_to_shipping to 1 without any item matching.

Temporary fix, in case someone needs :

--- a/Model/RulesApplier.php	2024-09-26 16:45:02
+++ b/Model/RulesApplier.php	2025-02-04 16:03:00
@@ -125,6 +125,9 @@
             if (!$this->validatorUtility->canProcessRule($rule, $address)) {
                 continue;
             }
+            if ($rule->getApplyToShipping()) {
+                $appliedRuleIds[$rule->getRuleId()] = $rule->getRuleId();
+            }
             if (!$skipValidation && !$rule->getActions()->validate($item)) {
                 if (!$this->childrenValidationLocator->isChildrenValidationRequired($item)) {
                     continue;

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @Nuranto,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

Coupon is applied, 1$ discount applied on shipping amount.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[Nuranto]

What if you replace equals or greater than with contains ?

[engcom-Bravo]

Hi @Nuranto,

Thanks for your update.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

We have replaced with contains still we are able to apply the discount.

Thanks.