Skip to content

Commit 430c0c7

Browse files
authored
fix(DX): Log all exceptions in developer mode (frappe#29195)
ALL exceptions - even validation errors. This is excessive logging but in development mode it should be fine and even helpful in debugging few issues.
1 parent 9c2bd23 commit 430c0c7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

frappe/app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
from frappe.middlewares import StaticDataMiddleware
2727
from frappe.utils import CallbackManager, cint, get_site_name
2828
from frappe.utils.data import escape_html
29-
from frappe.utils.error import log_error_snapshot
29+
from frappe.utils.error import log_error, log_error_snapshot
3030
from frappe.website.page_renderers.error_page import ErrorPage
3131
from frappe.website.serve import get_response
3232

@@ -390,7 +390,7 @@ def handle_exception(e):
390390
if hasattr(frappe.local, "login_manager"):
391391
frappe.local.login_manager.clear_cookies()
392392

393-
if http_status_code >= 500:
393+
if http_status_code >= 500 or frappe.conf.developer_mode:
394394
log_error_snapshot(e)
395395

396396
if frappe.conf.get("developer_mode") and not respond_as_json:

0 commit comments

Comments
 (0)