/etc/maininabox.conf MTA_STS_MODE value overwritten every start.sh run

[jvolkenant]

In testing out #1965, I took another look at how the variables are handled in start.sh in respect to creating /etc/mailinabox.conf. the value for MTA_STS_MODE gets overwritten if you put any value in since...

mailinabox/setup/start.sh

Line 97 in 8cda58f

MTA_STS_MODE=${MTA_STS_MODE-}

by that point in the code MTA_STS_MODE is empty, and it gets initialized to an empty variable every time. Only DEFAULT_... variables are available to carried forward.

In the current code things still work as the variable just gets set to enforce because the mailinabox.conf variable is empty

mailinabox/setup/web.sh

Line 135 in 8cda58f

| sed "s/MODE/${MTA_STS_MODE:-enforce}/" \

.

We should move the initialize to "enforce if empty" for MTA_STS_MODE to start.sh (as we should for all variables), so when you check a /etc/mailinabox.conf config it truely holds the config.

start.sh will need
MTA_STS_MODE=${DEFAULT_MTA_STS_MODE:-enforce}

web.sh
| sed "s/MODE/${MTA_STS_MODE}/" \

or something of the like. When I get some time I'll submit a PR.