Why does layersWithin take a distance in pixels?

[lstomsl]

I think this would be an extremely useful function if it took a search radius in meters. I have no idea how it is useful if it takes a search radius in screen pixels.

Am I missing something?

[leplatrem]

I think Leaflet has conversion functions from pixels to meters at the current zoom level (I did that somewhere already, but it was too long ago :))

I have no idea how it is useful if it takes a search radius in screen pixels.

It's useful for snapping for example :)

[haoliangyu]

@lstomsl

I am the developer of this function. As @leplatrem indicates, my original use case is to get layers within a bbox and select one of them for snapping in a custom filter function in our fork of Leaflet.Snap. A distance in pixels is used to provide a consistent user experience of snapping at different zoom levels.

I am fine with either meter or pixel as they are convertible: http://wiki.openstreetmap.org/wiki/Zoom_levels

[leplatrem]

We could add a layersWithinMeters() helper (As long as we don't go as far as implementing helpers for feets, yards, sticks, fingers or whatever crazy non metric unit 😄)