Skip to content

Commit 06b645b

Browse files
committed
It is no longer need to call resolve() on callbacks. (#11333)
1 parent fb55c6f commit 06b645b

File tree

3 files changed

+19
-65
lines changed

3 files changed

+19
-65
lines changed

src/devices/bus/technics/kn5000_extension.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,6 @@ void kn5000_extension_device::io_map(address_space_installer &space, offs_t star
3232
space.install_device(start, end, *dev, &kn5000_extension_interface::io_map);
3333
}
3434

35-
// FIXME: do we need these?
36-
//void kn5000_extension_device::device_resolve_objects()
37-
//{
38-
// m_firq_callback.resolve_safe();
39-
// m_irq_callback.resolve_safe();
40-
//}
41-
4235
void kn5000_extension_device::device_start()
4336
{
4437
}

src/devices/bus/technics/kn5000_extension.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ class kn5000_extension_device : public device_t, public device_single_card_slot_
4444
void io_map(address_space_installer &space, offs_t start, offs_t end);
4545

4646
protected:
47-
// FIXME: do we need these?
48-
// virtual void device_resolve_objects() override;
4947
virtual void device_start() override;
5048

5149
// FIXME: do we need these?

src/devices/cpu/tlcs900/tmp94c241.cpp

Lines changed: 19 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -170,42 +170,42 @@ static const struct {
170170

171171
tmp94c241_device::tmp94c241_device(const machine_config &mconfig, const char *tag, device_t *owner, u32 clock) :
172172
tlcs900h_device(mconfig, TMP94C241, tag, owner, clock),
173-
m_port0_read(*this),
173+
m_port0_read(*this, 0),
174174
m_port0_write(*this),
175-
m_port1_read(*this),
175+
m_port1_read(*this, 0),
176176
m_port1_write(*this),
177-
m_port2_read(*this),
177+
m_port2_read(*this, 0),
178178
m_port2_write(*this),
179-
m_port3_read(*this),
179+
m_port3_read(*this, 0),
180180
m_port3_write(*this),
181-
m_port4_read(*this),
181+
m_port4_read(*this, 0),
182182
m_port4_write(*this),
183-
m_port5_read(*this),
183+
m_port5_read(*this, 0),
184184
m_port5_write(*this),
185-
m_port6_read(*this),
185+
m_port6_read(*this, 0),
186186
m_port6_write(*this),
187-
m_port7_read(*this),
187+
m_port7_read(*this, 0),
188188
m_port7_write(*this),
189-
m_port8_read(*this),
189+
m_port8_read(*this, 0),
190190
m_port8_write(*this),
191-
m_porta_read(*this),
191+
m_porta_read(*this, 0),
192192
m_porta_write(*this),
193-
m_portb_read(*this),
193+
m_portb_read(*this, 0),
194194
m_portb_write(*this),
195-
m_portc_read(*this),
195+
m_portc_read(*this, 0),
196196
m_portc_write(*this),
197-
m_portd_read(*this),
197+
m_portd_read(*this, 0),
198198
m_portd_write(*this),
199-
m_porte_read(*this),
199+
m_porte_read(*this, 0),
200200
m_porte_write(*this),
201-
m_portf_read(*this),
201+
m_portf_read(*this, 0),
202202
m_portf_write(*this),
203-
m_portg_read(*this),
204-
m_porth_read(*this),
203+
m_portg_read(*this, 0),
204+
m_porth_read(*this, 0),
205205
m_porth_write(*this),
206-
m_portz_read(*this),
206+
m_portz_read(*this, 0),
207207
m_portz_write(*this),
208-
m_an_read(*this),
208+
m_an_read(*this, 0),
209209
m_port_latch{ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
210210
m_port_control{ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
211211
m_port_function{ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 },
@@ -290,43 +290,6 @@ void tmp94c241_device::device_start()
290290
save_item(NAME(m_dram_refresh));
291291
save_item(NAME(m_dram_access));
292292
save_item(NAME(m_da_drive));
293-
294-
m_port0_read.resolve_safe(0);
295-
m_port0_write.resolve_safe();
296-
m_port1_read.resolve_safe(0);
297-
m_port1_write.resolve_safe();
298-
m_port2_read.resolve_safe(0);
299-
m_port2_write.resolve_safe();
300-
m_port3_read.resolve_safe(0);
301-
m_port3_write.resolve_safe();
302-
m_port4_read.resolve_safe(0);
303-
m_port4_write.resolve_safe();
304-
m_port5_read.resolve_safe(0);
305-
m_port5_write.resolve_safe();
306-
m_port6_read.resolve_safe(0);
307-
m_port6_write.resolve_safe();
308-
m_port7_read.resolve_safe(0);
309-
m_port7_write.resolve_safe();
310-
m_port8_read.resolve_safe(0);
311-
m_port8_write.resolve_safe();
312-
m_porta_read.resolve_safe(0);
313-
m_porta_write.resolve_safe();
314-
m_portb_read.resolve_safe(0);
315-
m_portb_write.resolve_safe();
316-
m_portc_read.resolve_safe(0);
317-
m_portc_write.resolve_safe();
318-
m_portd_read.resolve_safe(0);
319-
m_portd_write.resolve_safe();
320-
m_porte_read.resolve_safe(0);
321-
m_porte_write.resolve_safe();
322-
m_portf_read.resolve_safe(0);
323-
m_portf_write.resolve_safe();
324-
m_portg_read.resolve_safe(0);
325-
m_porth_read.resolve_safe(0);
326-
m_porth_write.resolve_safe();
327-
m_portz_read.resolve_safe(0);
328-
m_portz_write.resolve_safe();
329-
m_an_read.resolve_all_safe(0);
330293
}
331294

332295

0 commit comments

Comments
 (0)