pytest-shutil 1.7.0: pytest is failing

[kloczek]

I'm trying to package your module as rpm packag. So I'm using typical in such case build, install and test cycle used on building package from non-root account:

• "setup.py build"
• "setup.py install --root </install/prefix>"
• "pytest with PYTHONPATH pointing to setearch and sitelib inside </install/prefix>

May I ask for help because few units are failing:

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-pytest-shutil-1.7.0-14.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-pytest-shutil-1.7.0-14.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.11, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
benchmark: 3.4.1 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: /home/tkloczko/rpmbuild/BUILD/pytest-shutil-1.7.0, configfile: setup.cfg
plugins: shutil-1.7.0, forked-1.3.0, virtualenv-1.7.0, expect-1.1.0, flake8-1.0.7, timeout-1.4.2, betamax-0.8.1, freezegun-0.4.2, case-1.5.3, isort-1.3.0, aspectlib-1.5.2, toolbox-0.5, mock-3.6.1, rerunfailures-9.1.1, requests-mock-1.9.3, cov-2.12.1, pyfakefs-4.5.0, flaky-3.7.0, benchmark-3.4.1, xdist-2.3.0, pylama-7.7.1, datadir-1.3.1, regressions-2.2.0, cases-3.6.3, hypothesis-6.14.4, xprocess-0.18.1, black-0.3.12, checkdocs-2.7.1, anyio-3.3.0, Faker-8.11.0, asyncio-0.15.1, trio-0.7.0, httpbin-1.0.0, subtests-0.5.0
collected 58 items

. F                                                                                                                                                                  [  1%]
tests/integration/test_cmdline_integration.py ..                                                                                                                     [  5%]
tests/integration/test_env_integration.py ....                                                                                                                       [ 12%]
tests/integration/test_run_integration.py ................x..                                                                                                        [ 45%]
tests/integration/test_workspace_integration.py ..                                                                                                                   [ 49%]
tests/unit/test_cmdline.py ....                                                                                                                                      [ 56%]
tests/unit/test_env.py .......                                                                                                                                       [ 68%]
tests/unit/test_run.py .......x..xxxxxxxx                                                                                                                            [100%]

================================================================================= FAILURES =================================================================================
_______________________________________________________________________________ test session _______________________________________________________________________________

cls = <class '_pytest.runner.CallInfo'>, func = <function call_runtest_hook.<locals>.<lambda> at 0x7f1e27628790>, when = 'call'
reraise = (<class '_pytest.outcomes.Exit'>, <class 'KeyboardInterrupt'>)

    @classmethod
    def from_call(
        cls,
        func: "Callable[[], TResult]",
        when: "Literal['collect', 'setup', 'call', 'teardown']",
        reraise: Optional[
            Union[Type[BaseException], Tuple[Type[BaseException], ...]]
        ] = None,
    ) -> "CallInfo[TResult]":
        excinfo = None
        start = timing.time()
        precise_start = timing.perf_counter()
        try:
>           result: Optional[TResult] = func()

/usr/lib/python3.8/site-packages/_pytest/runner.py:311:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>       lambda: ihook(item=item, **kwds), when=when, reraise=reraise
    )

/usr/lib/python3.8/site-packages/_pytest/runner.py:255:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <_HookCaller 'pytest_runtest_call'>, args = (), kwargs = {'item': <CheckdocsItem project>}, notincall = set()

    def __call__(self, *args, **kwargs):
        if args:
            raise TypeError("hook calling supports only keyword arguments")
        assert not self.is_historic()
        if self.spec and self.spec.argnames:
            notincall = (
                set(self.spec.argnames) - set(["__multicall__"]) - set(kwargs.keys())
            )
            if notincall:
                warnings.warn(
                    "Argument(s) {} which are declared in the hookspec "
                    "can not be found in this hook call".format(tuple(notincall)),
                    stacklevel=2,
                )
>       return self._hookexec(self, self.get_hookimpls(), kwargs)

/usr/lib/python3.8/site-packages/pluggy/hooks.py:286:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <_pytest.config.PytestPluginManager object at 0x7f1e47788790>, hook = <_HookCaller 'pytest_runtest_call'>
methods = [<HookImpl plugin_name='runner', plugin=<module '_pytest.runner' from '/usr/lib/python3.8/site-packages/_pytest/runner...pper name='/dev/null' mode='r' encoding='UTF-8'>> _state='suspended' _in_suspended=False> _capture_fixture=None>>, ...]
kwargs = {'item': <CheckdocsItem project>}

    def _hookexec(self, hook, methods, kwargs):
        # called from all hookcaller instances.
        # enable_tracing will set its own wrapping function at self._inner_hookexec
>       return self._inner_hookexec(hook, methods, kwargs)

/usr/lib/python3.8/site-packages/pluggy/manager.py:93:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

hook = <_HookCaller 'pytest_runtest_call'>
methods = [<HookImpl plugin_name='runner', plugin=<module '_pytest.runner' from '/usr/lib/python3.8/site-packages/_pytest/runner...pper name='/dev/null' mode='r' encoding='UTF-8'>> _state='suspended' _in_suspended=False> _capture_fixture=None>>, ...]
kwargs = {'item': <CheckdocsItem project>}

>   self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
        methods,
        kwargs,
        firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
    )

/usr/lib/python3.8/site-packages/pluggy/manager.py:84:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

hook_impls = [<HookImpl plugin_name='runner', plugin=<module '_pytest.runner' from '/usr/lib/python3.8/site-packages/_pytest/runner...pper name='/dev/null' mode='r' encoding='UTF-8'>> _state='suspended' _in_suspended=False> _capture_fixture=None>>, ...]
caller_kwargs = {'item': <CheckdocsItem project>}, firstresult = False

    def _multicall(hook_impls, caller_kwargs, firstresult=False):
        """Execute a call into multiple python functions/methods and return the
        result(s).

        ``caller_kwargs`` comes from _HookCaller.__call__().
        """
        __tracebackhide__ = True
        results = []
        excinfo = None
        try:  # run impl and wrapper setup functions in a loop
            teardowns = []
            try:
                for hook_impl in reversed(hook_impls):
                    try:
                        args = [caller_kwargs[argname] for argname in hook_impl.argnames]
                    except KeyError:
                        for argname in hook_impl.argnames:
                            if argname not in caller_kwargs:
                                raise HookCallError(
                                    "hook call must provide argument %r" % (argname,)
                                )

                    if hook_impl.hookwrapper:
                        try:
                            gen = hook_impl.function(*args)
                            next(gen)  # first yield
                            teardowns.append(gen)
                        except StopIteration:
                            _raise_wrapfail(gen, "did not yield")
                    else:
                        res = hook_impl.function(*args)
                        if res is not None:
                            results.append(res)
                            if firstresult:  # halt further impl calls
                                break
            except BaseException:
                excinfo = sys.exc_info()
        finally:
            if firstresult:  # first result hooks return a single value
                outcome = _Result(results[0] if results else None, excinfo)
            else:
                outcome = _Result(results, excinfo)

            # run all wrapper post-yield blocks
            for gen in reversed(teardowns):
                try:
                    gen.send(outcome)
                    _raise_wrapfail(gen, "has second yield")
                except StopIteration:
                    pass

>           return outcome.get_result()

/usr/lib/python3.8/site-packages/pluggy/callers.py:208:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <pluggy.callers._Result object at 0x7f1e27550880>

    def get_result(self):
        """Get the result(s) for this hook call.

        If the hook was marked as a ``firstresult`` only a single value
        will be returned otherwise a list of results.
        """
        __tracebackhide__ = True
        if self._excinfo is None:
            return self._result
        else:
            ex = self._excinfo
            if _py3:
>               raise ex[1].with_traceback(ex[2])

/usr/lib/python3.8/site-packages/pluggy/callers.py:80:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

hook_impls = [<HookImpl plugin_name='runner', plugin=<module '_pytest.runner' from '/usr/lib/python3.8/site-packages/_pytest/runner...pper name='/dev/null' mode='r' encoding='UTF-8'>> _state='suspended' _in_suspended=False> _capture_fixture=None>>, ...]
caller_kwargs = {'item': <CheckdocsItem project>}, firstresult = False

    def _multicall(hook_impls, caller_kwargs, firstresult=False):
        """Execute a call into multiple python functions/methods and return the
        result(s).

        ``caller_kwargs`` comes from _HookCaller.__call__().
        """
        __tracebackhide__ = True
        results = []
        excinfo = None
        try:  # run impl and wrapper setup functions in a loop
            teardowns = []
            try:
                for hook_impl in reversed(hook_impls):
                    try:
                        args = [caller_kwargs[argname] for argname in hook_impl.argnames]
                    except KeyError:
                        for argname in hook_impl.argnames:
                            if argname not in caller_kwargs:
                                raise HookCallError(
                                    "hook call must provide argument %r" % (argname,)
                                )

                    if hook_impl.hookwrapper:
                        try:
                            gen = hook_impl.function(*args)
                            next(gen)  # first yield
                            teardowns.append(gen)
                        except StopIteration:
                            _raise_wrapfail(gen, "did not yield")
                    else:
>                       res = hook_impl.function(*args)

/usr/lib/python3.8/site-packages/pluggy/callers.py:187:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

item = <CheckdocsItem project>

    def pytest_runtest_call(item: Item) -> None:
        _update_current_test_var(item, "call")
        try:
            del sys.last_type
            del sys.last_value
            del sys.last_traceback
        except AttributeError:
            pass
        try:
            item.runtest()
        except Exception as e:
            # Store trace info to allow postmortem debugging
            sys.last_type = type(e)
            sys.last_value = e
            assert e.__traceback__ is not None
            # Skip *this* frame
            sys.last_traceback = e.__traceback__.tb_next
>           raise e

/usr/lib/python3.8/site-packages/_pytest/runner.py:170:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

item = <CheckdocsItem project>

    def pytest_runtest_call(item: Item) -> None:
        _update_current_test_var(item, "call")
        try:
            del sys.last_type
            del sys.last_value
            del sys.last_traceback
        except AttributeError:
            pass
        try:
>           item.runtest()

/usr/lib/python3.8/site-packages/_pytest/runner.py:162:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <CheckdocsItem project>

    def runtest(self):
        desc = self.get_long_description()
        method_name = f"run_{re.sub('[-/]', '_', desc.content_type)}"
>       getattr(self, method_name)(desc)

/usr/lib/python3.8/site-packages/pytest_checkdocs/__init__.py:42:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <CheckdocsItem project>
desc = '# pytest-shutil\n\n\nThis library is a goodie-bag of Unix shell and environment management tools for automated tests....args\n\n### 1.0.1 (2015-12-23)\n\n *  Packaging bugfix\n\n### 1.0.0 (2015-12-21)\n\n *  Initial public release\n\n\n\n'

    def run_text_x_rst(self, desc):
        with self.monkey_patch_system_message() as reports:
            self.rst2html(desc)
>       assert not reports
E       AssertionError: assert not ['Unexpected indentation.', 'Block quote ends without a blank line; unexpected unindent.', 'Inline literal start-strin...ng without end-string.', 'Unexpected indentation.', 'Block quote ends without a blank line; unexpected unindent.', ...]

/usr/lib/python3.8/site-packages/pytest_checkdocs/__init__.py:50: AssertionError
--------------------------------------------------------------------------- Captured stderr call ---------------------------------------------------------------------------
<string>:12: (ERROR/3) Unexpected indentation.
<string>:15: (WARNING/2) Block quote ends without a blank line; unexpected unindent.
<string>:15: (WARNING/2) Inline literal start-string without end-string.
<string>:15: (WARNING/2) Inline interpreted text or phrase reference start-string without end-string.
<string>:22: (ERROR/3) Unexpected indentation.
<string>:33: (WARNING/2) Block quote ends without a blank line; unexpected unindent.
<string>:33: (WARNING/2) Inline literal start-string without end-string.
<string>:33: (WARNING/2) Inline interpreted text or phrase reference start-string without end-string.
<string>:81: (WARNING/2) Inline emphasis start-string without end-string.
============================================================================= warnings summary =============================================================================
tests/integration/test_workspace_integration.py::test_workspace_fixture_autodelete
  /home/tkloczko/rpmbuild/BUILD/pytest-shutil-1.7.0/tests/integration/test_workspace_integration.py:28: PytestWarning: Value of environment variable WORKSPACE type should be str, but got local('/tmp/pytest-of-tkloczko/pytest-78/test_workspace_fixture_autodel0/tmp') (type: LocalPath); converted to str implicitly
    monkeypatch.setenv('WORKSPACE', workspace)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
========================================================================= short test summary info ==========================================================================
XFAIL tests/integration/test_run_integration.py::test_run_in_subprocess_passes_stdout
  condition: sys.version_info >= (3, 0, 0)
XFAIL tests/unit/test_run.py::test_run_in_runpickleable_function
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runbound_method
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runbound_method_on_unpickleable_class
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_rununbound_method
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_rununbound_method_on_unpickleable_class
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runstaticmethod
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runstaticmethod_on_unpickleable_class
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runclassmethod
  python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runclassmethod_on_unpickleable_class
  python3.5 api changes
FAILED ::project - AssertionError: assert not ['Unexpected indentation.', 'Block quote ends without a blank line; unexpected unindent.', 'Inline literal start-strin...ng...
=========================================================== 1 failed, 46 passed, 10 xfailed, 1 warning in 14.20s ===========================================================
pytest-xprocess reminder::Be sure to terminate the started process by running 'pytest --xkill' if you have not explicitly done so in your fixture with 'xprocess.getinfo(<process_name>).terminate()'.

[kloczek]

Closing.
It was buggy pytest extension.

[kloczek]

After apply e1a8240 still have one unit failing

+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-pytest-shutil-1.7.0-19.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-pytest-shutil-1.7.0-19.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra -m 'not network'
==================================================================================== test session starts ====================================================================================
platform linux -- Python 3.8.16, pytest-7.3.1, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/pytest-plugins-1.7.0/pytest-shutil
configfile: setup.cfg
plugins: shutil-1.7.0, mock-3.10.0, anyio-3.6.2, datadir-1.4.1, regressions-2.4.2, pytest_param_files-0.3.4
collected 56 items

tests/integration/test_cmdline_integration.py ..                                                                                                                                      [  3%]
tests/integration/test_env_integration.py ....                                                                                                                                        [ 10%]
tests/integration/test_run_integration.py ................x..                                                                                                                         [ 44%]
tests/integration/test_workspace_integration.py ..                                                                                                                                    [ 48%]
tests/unit/test_cmdline.py .F..                                                                                                                                                       [ 55%]
tests/unit/test_env.py .......                                                                                                                                                        [ 67%]
tests/unit/test_run.py .......x..xxxxxxxx                                                                                                                                             [100%]

========================================================================================= FAILURES ==========================================================================================
___________________________________________________________________________________ test_pretty_formatter ___________________________________________________________________________________

    def test_pretty_formatter():
        f = cmdline.PrettyFormatter()
        f.title('A Title')
        f.hr()
        f.p('A Paragraph', 'red')
>       assert f.buffer == [
            '\x1b[1m\x1b[34m  A Title\x1b[0m',
            '\x1b[1m\x1b[34m--------------------------------------------------------------------------------\x1b[0m',
            '\x1b[31mA Paragraph\x1b[0m'
            ]
E       AssertionError: assert ['  A Title',...'A Paragraph'] == ['\x1b[1m\x1b...graph\x1b[0m']
E         At index 0 diff: '  A Title' != '\x1b[1m\x1b[34m  A Title\x1b[0m'
E         Use -v to get more diff

/home/tkloczko/rpmbuild/BUILD/pytest-plugins-1.7.0/pytest-shutil/tests/unit/test_cmdline.py:18: AssertionError
===================================================================================== warnings summary ======================================================================================
../../../BUILDROOT/python-pytest-shutil-1.7.0-19.fc35.x86_64/usr/lib/python3.8/site-packages/pytest_shutil/run.py:6
  /home/tkloczko/rpmbuild/BUILDROOT/python-pytest-shutil-1.7.0-19.fc35.x86_64/usr/lib/python3.8/site-packages/pytest_shutil/run.py:6: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

tests/integration/test_workspace_integration.py::test_workspace_fixture_autodelete
  /home/tkloczko/rpmbuild/BUILD/pytest-plugins-1.7.0/pytest-shutil/tests/integration/test_workspace_integration.py:28: PytestWarning: Value of environment variable WORKSPACE type should be str, but got local('/tmp/pytest-of-tkloczko/pytest-32/test_workspace_fixture_autodel0/tmp') (type: LocalPath); converted to str implicitly
    monkeypatch.setenv('WORKSPACE', workspace)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================================== short test summary info ==================================================================================
XFAIL tests/integration/test_run_integration.py::test_run_in_subprocess_passes_stdout - condition: sys.version_info >= (3, 0, 0)
XFAIL tests/unit/test_run.py::test_run_in_runpickleable_function - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runbound_method - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runbound_method_on_unpickleable_class - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_rununbound_method - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_rununbound_method_on_unpickleable_class - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runstaticmethod - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runstaticmethod_on_unpickleable_class - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runclassmethod - python3.5 api changes
XFAIL tests/unit/test_run.py::test_run_in_runclassmethod_on_unpickleable_class - python3.5 api changes
FAILED tests/unit/test_cmdline.py::test_pretty_formatter - AssertionError: assert ['  A Title',...'A Paragraph'] == ['\x1b[1m\x1b...graph\x1b[0m']
=================================================================== 1 failed, 45 passed, 10 xfailed, 2 warnings in 3.48s ====================================================================