binja: move to VM-Install-With-Installer

Author: sreinhardt

Diff for: packages/binaryninja.vm/tools/chocolateyinstall.ps1

@@ -1,29 +1,34 @@
 $ErrorActionPreference = 'Stop'
 Import-Module vm.common -Force -DisableNameChecking
 
-try {
-  $toolName = 'binaryninja'
-  $category = 'Disassemblers'
-
-  $packageArgs = @{
-    packageName  = ${Env:ChocolateyPackageName}
-    fileType     = 'exe'
-    silentArgs   = '/S /ALLUSERS=1'
-    url          = 'https://cdn.binary.ninja/installers/binaryninja_free_win64.exe'
-    checksum     = '426aa8219415a64df90562274ae7e420471934c60f3a19c459e982467469cf55'
-    checksumType = 'sha256'
-  }
+$installFile = "binaryninja_free_win64.exe"
 
-  Install-ChocolateyPackage @packageArgs
+function Get-CurrentHash {
+  param (
+    [string]$url      = "https://binary.ninja/js/hashes.json",
+    [string]$installFile = $installFile
+  )
+  $json = Invoke-WebRequest -Uri $url 
+  $json = ConvertFrom-Json $json
+  return $json.Hashes.$installFile
+}
 
-  $toolDir = Join-Path ${Env:ProgramFiles} "Vector35"  -Resolve
-  $toolDir = Join-Path $toolDir "BinaryNinja"  -Resolve
-  $executablePath = Join-Path $toolDir "binaryninja.exe" -Resolve
+try {
+  $url = "https://cdn.binary.ninja/installers/$installFile"
+  $hash = Get-CurrentHash
+  $toolDir = Join-Path ${Env:ProgramFiles} "Vector35"
+  $toolDir = Join-Path $toolDir "BinaryNinja"
+  $executablePath = Join-Path $toolDir "binaryninja.exe"
 
-  Install-BinFile -Name $toolname -Path $executablePath
-  $executableIcon = Join-Path $toolDir "icon.ico" -Resolve
-  VM-Install-Shortcut -toolName "binja" -category $category -executablePath $executablePath -IconLocation $executableIcon
+  VM-Install-With-Installer -toolName 'binaryninja' `
+    -category 'Disassemblers' `
+    -fileType 'EXE' `
+    -silentArgs '/S /ALLUSERS=1' `
+    -executablePath $executablePath `
+    -url $url `
+    -sha256 $hash `
+    -consoleApp $false
 
 } catch {
   VM-Write-Log-Exception $_
-}
+}

Diff for: packages/binaryninja.vm/tools/chocolateyuninstall.ps1

@@ -1,10 +1,7 @@
 $ErrorActionPreference = 'Continue'
 Import-Module vm.common -Force -DisableNameChecking
 
-$toolName = 'binaryninja'
-$category = 'Disassemblers'
-VM-Remove-Tool-Shortcut $toolName $category
-
-Uninstall-BinFile -Name $toolName
-
-VM-Uninstall-With-Uninstaller "Binary Ninja*" $category "EXE" "/S /ALLUSERS=1"
+VM-Uninstall-With-Uninstaller -toolName "Binary Ninja*" `
+    -category "Disassemblers" `
+    -fileType "EXE" `
+    -silentArgs "/S /ALLUSERS=1"