set default value for filter: hideNoActivitySince

Author: lbayle

timetracking/time_tracking.php

@@ -79,7 +79,7 @@ protected function display() {
 
             $defaultDate = Tools::getSecurePOSTStringValue('date',date("Y-m-d", time()));
             $defaultBugid = Tools::getSecurePOSTIntValue('bugid',0);
-            
+
             $sessionProjectId = isset($_SESSION['projectid']) ? $_SESSION['projectid'] : 0;
             $defaultProjectid = Tools::getSecurePOSTIntValue('projectid',$sessionProjectId);
 
@@ -151,6 +151,14 @@ protected function display() {
             $this->smartyHelper->assign('isHideForbidenStatus', $isHideForbidenStatus);
 
             $hideNoActivitySince = $managed_user->getTimetrackingFilter('hideNoActivitySince');
+            if (0 == $hideNoActivitySince) {
+               // uncheck, but set value to default (instead of zero)
+               $this->smartyHelper->assign('isHideNoActivitySince', false);
+               $defaultFilters = Tools::doubleExplode(':', ',', Config::default_timetrackingFilters);
+               $hideNoActivitySince =  $defaultFilters['hideNoActivitySince'];
+            } else {
+               $this->smartyHelper->assign('isHideNoActivitySince', true);
+            }
             $this->smartyHelper->assign('hideNoActivitySince', $hideNoActivitySince);
 
             $availableIssues = TimeTrackingTools::getIssues($this->teamid, $defaultProjectid, $isOnlyAssignedTo, $managed_user->getId(), $projList, $isHideResolved, $isHideForbidenStatus, $defaultBugid, $hideNoActivitySince);

tpl/time_tracking.html

@@ -48,7 +48,7 @@ <h2>{$managedUser_realname}</h2>
             </select>
             {/if}
             <a title="{t}Set filters{/t}" id="filters" style="text-decoration: none" href="{$page}">
-               {if $isOnlyAssignedTo || $isHideResolved || (0 != $hideNoActivitySince)}
+               {if $isOnlyAssignedTo || $isHideResolved || ($isHideNoActivitySince)}
                <img border="0" width="16" height="12" align="absmiddle" src="images/im-filter-active.png" alt="{t}Set filters{/t}" />
                {else}
                <img border="0" width="16" height="12" align="absmiddle" src="images/im-filter.png" alt="{t}Set filters{/t}" />
@@ -141,7 +141,7 @@ <h2>{$managedUser_realname}</h2>
 
                <table class="invisible">
                   <tr>
-                     <td><input type="checkbox" id="cb_hideNoActivitySince" name="cb_hideNoActivitySince" {if (0 != $hideNoActivitySince)} checked="checked" {/if}/></td>
+                     <td><input type="checkbox" id="cb_hideNoActivitySince" name="cb_hideNoActivitySince" {if ($isHideNoActivitySince)} checked="checked" {/if}/></td>
                      <td>
                         <label>{t}Hide tasks with no activity since{/t} </label>
                         <input id="hideNoActivitySince" name="hideNoActivitySince" value="{$hideNoActivitySince}" style="width:20px;"/>