Skip to content

Commit b2fde12

Browse files
author
Gustavo De Micheli
committed
Kafka 2.3.1
1 parent a02a82a commit b2fde12

File tree

6 files changed

+17
-28
lines changed

6 files changed

+17
-28
lines changed

build.sbt

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import sbtrelease.Version
22

33
parallelExecution in ThisBuild := false
44

5-
val kafkaVersion = "2.0.0"
6-
val confluentVersion = "5.0.0"
5+
val kafkaVersion = "2.3.1"
6+
val confluentVersion = "5.3.1"
77
val akkaVersion = "2.5.14"
88

99
lazy val commonSettings = Seq(

embedded-kafka/src/main/scala/net/manub/embeddedkafka/avro/avroMarshallers.scala

+2-15
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ import org.apache.avro.specific.{
1313
import org.apache.kafka.common.serialization.{Deserializer, Serializer}
1414

1515
class KafkaAvroDeserializer[T <: SpecificRecord](schema: Schema)
16-
extends Deserializer[T]
17-
with NoOpConfiguration
18-
with NoOpClose {
16+
extends Deserializer[T] {
1917

2018
private val reader = new SpecificDatumReader[T](schema)
2119

@@ -25,10 +23,7 @@ class KafkaAvroDeserializer[T <: SpecificRecord](schema: Schema)
2523
}
2624
}
2725

28-
class KafkaAvroSerializer[T <: SpecificRecord]()
29-
extends Serializer[T]
30-
with NoOpConfiguration
31-
with NoOpClose {
26+
class KafkaAvroSerializer[T <: SpecificRecord]() extends Serializer[T] {
3227

3328
private def toBytes(nullableData: T): Array[Byte] =
3429
Option(nullableData).fold[Array[Byte]](null) { data =>
@@ -46,11 +41,3 @@ class KafkaAvroSerializer[T <: SpecificRecord]()
4641
override def serialize(topic: String, data: T): Array[Byte] =
4742
toBytes(data)
4843
}
49-
50-
sealed trait NoOpConfiguration {
51-
def configure(configs: java.util.Map[String, _], isKey: Boolean): Unit = ()
52-
}
53-
54-
sealed trait NoOpClose {
55-
def close(): Unit = ()
56-
}

kafka-streams/src/main/scala/net/manub/embeddedkafka/streams/EmbeddedKafkaStreams.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ trait EmbeddedKafkaStreams extends EmbeddedKafka with TestStreamsConfig {
3030
topicsToCreate.foreach(topic => createCustomTopic(topic))
3131
val streamId = UUIDs.newUuid().toString
3232
val streams =
33-
new KafkaStreams(topology, streamConfig(streamId, extraConfig))
33+
new KafkaStreams(topology, streamProps(streamId, extraConfig))
3434
streams.start()
3535
try {
3636
block

kafka-streams/src/main/scala/net/manub/embeddedkafka/streams/TestStreamsConfig.scala

+8-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package net.manub.embeddedkafka.streams
22

33
import java.nio.file.Files
4+
import java.util.Properties
45

56
import net.manub.embeddedkafka.EmbeddedKafkaConfig
67
import org.apache.kafka.clients.consumer.{ConsumerConfig, OffsetResetStrategy}
@@ -17,9 +18,9 @@ trait TestStreamsConfig {
1718
* @param kafkaConfig the Kafka test configuration
1819
* @return the Streams configuration
1920
*/
20-
def streamConfig(streamName: String,
21-
extraConfig: Map[String, AnyRef] = Map.empty)(
22-
implicit kafkaConfig: EmbeddedKafkaConfig): StreamsConfig = {
21+
def streamProps(streamName: String,
22+
extraConfig: Map[String, AnyRef] = Map.empty)(
23+
implicit kafkaConfig: EmbeddedKafkaConfig): Properties = {
2324
import scala.collection.JavaConverters._
2425

2526
val defaultConfig = Map(
@@ -33,6 +34,9 @@ trait TestStreamsConfig {
3334
)
3435
val configOverwrittenByExtra = defaultConfig ++
3536
extraConfig
36-
new StreamsConfig(configOverwrittenByExtra.asJava)
37+
38+
val props = new Properties()
39+
props.putAll(configOverwrittenByExtra.asJava)
40+
props
3741
}
3842
}

schema-registry/src/main/scala/net.manub.embeddedkafka/schemaregistry/streams/EmbeddedKafkaStreamsWithSchemaRegistry.scala

+3-5
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,9 @@ trait EmbeddedKafkaStreamsWithSchemaRegistry
3939
withRunningKafka {
4040
topicsToCreate.foreach(topic => createCustomTopic(topic))
4141
val streamId = UUIDs.newUuid().toString
42-
val streams =
43-
new KafkaStreams(
44-
topology,
45-
streamConfig(streamId,
46-
extraConfig ++ consumerConfigForSchemaRegistry))
42+
val streams = new KafkaStreams(
43+
topology,
44+
streamProps(streamId, extraConfig ++ consumerConfigForSchemaRegistry))
4745
streams.start()
4846
try {
4947
block

version.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
version in ThisBuild := "2.1.0-SNAPSHOT"
1+
version in ThisBuild := "2.3.1-SNAPSHOT"

0 commit comments

Comments
 (0)