fix: crash with unknown products

manuel-rw · manuel-rw · commit 397ce643b659 · 2024-01-27T15:51:44.000+01:00
diff --git a/GrocyScanner.Core/ValueCalculator/BestProductValueCalculator.cs b/GrocyScanner.Core/ValueCalculator/BestProductValueCalculator.cs
@@ -11,8 +11,8 @@ public BestProductValueCalculator(IValueCalculator valueCalculator)
         _valueCalculator = valueCalculator;
     }
 
-    public Product GetProductWithMostValue(IEnumerable<Product> products)
+    public Product? GetProductWithMostValue(IEnumerable<Product> products)
     {
-        return products.OrderByDescending(product => _valueCalculator.CalculateValue(product)).First();
+        return products.MaxBy(product => _valueCalculator.CalculateValue(product));
     }
 }
diff --git a/GrocyScanner.Core/ValueCalculator/IBestValueCalculator.cs b/GrocyScanner.Core/ValueCalculator/IBestValueCalculator.cs
@@ -4,5 +4,5 @@ namespace GrocyScanner.Core.ValueCalculator;
 
 public interface IBestValueCalculator
 {
-    public Product GetProductWithMostValue(IEnumerable<Product> products);
+    public Product? GetProductWithMostValue(IEnumerable<Product> products);
 }

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,8 @@ public BestProductValueCalculator(IValueCalculator valueCalculator)`
`11`	`11`	`_valueCalculator = valueCalculator;`
`12`	`12`	`}`
`13`	`13`
`14`		`- public Product GetProductWithMostValue(IEnumerable<Product> products)`
	`14`	`+ public Product? GetProductWithMostValue(IEnumerable<Product> products)`
`15`	`15`	`{`
`16`		`- return products.OrderByDescending(product => _valueCalculator.CalculateValue(product)).First();`
	`16`	`+ return products.MaxBy(product => _valueCalculator.CalculateValue(product));`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,5 +4,5 @@ namespace GrocyScanner.Core.ValueCalculator;`
`4`	`4`
`5`	`5`	`public interface IBestValueCalculator`
`6`	`6`	`{`
`7`		`- public Product GetProductWithMostValue(IEnumerable<Product> products);`
	`7`	`+ public Product? GetProductWithMostValue(IEnumerable<Product> products);`
`8`	`8`	`}`