fix: crash with unknown products

manuel-rw · Jan 27, 2024 · 397ce64 · 397ce64
1 parent bccb271
commit 397ce64
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/GrocyScanner.Core/ValueCalculator/BestProductValueCalculator.cs b/GrocyScanner.Core/ValueCalculator/BestProductValueCalculator.cs
@@ -11,8 +11,8 @@ public BestProductValueCalculator(IValueCalculator valueCalculator)
         _valueCalculator = valueCalculator;
     }
 
-    public Product GetProductWithMostValue(IEnumerable<Product> products)
+    public Product? GetProductWithMostValue(IEnumerable<Product> products)
     {
-        return products.OrderByDescending(product => _valueCalculator.CalculateValue(product)).First();
+        return products.MaxBy(product => _valueCalculator.CalculateValue(product));
     }
 }
diff --git a/GrocyScanner.Core/ValueCalculator/IBestValueCalculator.cs b/GrocyScanner.Core/ValueCalculator/IBestValueCalculator.cs
@@ -4,5 +4,5 @@ namespace GrocyScanner.Core.ValueCalculator;
 
 public interface IBestValueCalculator
 {
-    public Product GetProductWithMostValue(IEnumerable<Product> products);
+    public Product? GetProductWithMostValue(IEnumerable<Product> products);
 }