template to avoid dep on std::string + ignore old world cast inside zlib macros

Author: Dane Springmeyer

include/gzip/compress.hpp

@@ -2,6 +2,7 @@
 
 // zlib
 #include <zlib.h>
+
 // std
 #include <limits>
 #include <stdexcept>
@@ -25,7 +26,8 @@ class Compressor
     {
     }
 
-    void compress(std::string& output,
+    template <typename InputType>
+    void compress(InputType & output,
                   const char* data,
                   std::size_t size) const
     {
@@ -65,10 +67,13 @@ class Compressor
         // with a default value of 8 for mem_level and our window_bits of 15
         // this is 128Kb
 
+        #pragma GCC diagnostic push
+        #pragma GCC diagnostic ignored "-Wold-style-cast"
         if (deflateInit2(&deflate_s, level_, Z_DEFLATED, window_bits, mem_level, strategy_) != Z_OK)
         {
             throw std::runtime_error("deflate init failed");
         }
+        #pragma GCC diagnostic pop
 
         deflate_s.next_in = reinterpret_cast<z_const Bytef*>(data);
         deflate_s.avail_in = static_cast<unsigned int>(size);

include/gzip/decompress.hpp

@@ -2,6 +2,7 @@
 
 // zlib
 #include <zlib.h>
+
 // std
 #include <limits>
 #include <stdexcept>
@@ -19,7 +20,8 @@ class Decompressor
     {
     }
 
-    void decompress(std::string& output,
+    template <typename OutputType>
+    void decompress(OutputType & output,
                     const char* data,
                     std::size_t size) const
     {
@@ -41,10 +43,13 @@ class Decompressor
         // (8 to 15) + 32 to automatically detect gzip/zlib header
         constexpr int window_bits = 15 + 32; // auto with windowbits of 15
 
+        #pragma GCC diagnostic push
+        #pragma GCC diagnostic ignored "-Wold-style-cast"
         if (inflateInit2(&inflate_s, window_bits) != Z_OK)
         {
             throw std::runtime_error("inflate init failed");
         }
+        #pragma GCC diagnostic pop
         inflate_s.next_in = reinterpret_cast<z_const Bytef*>(data);
 
 #ifdef DEBUG