-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions by default #98
Comments
Could you clarify on the impact of this? Are there downside of adding this? In general my feeling is that, all permissions that are required by this library should also be added to the Manifest. |
Is it possible to do this with a simple configuration setting? If yes, I think this would be perfect. |
The problem that fixed in #90 also appears on my app.
Similar to the location permission, we should thinking about to add the service permissions to the library
AndroidManifest
file.If we don't want it, maybe for the reason that not all apps will use the active navigation notification, we should check for available permissions and use the given service only when permission is set.
I tend to add the permission to the library. What's your opinions to that?
The text was updated successfully, but these errors were encountered: