Skip to content

Commit 54ea698

Browse files
committed
Merge pull request #175 from vontio/master
add log length
2 parents 76533fd + 821bba5 commit 54ea698

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

WebViewJavascriptBridge/WebViewJavascriptBridge.h

100644100755
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView webViewDelegate:(WVJB_WEBVIEW_DELEGATE_TYPE*)webViewDelegate handler:(WVJBHandler)handler;
3030
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView webViewDelegate:(WVJB_WEBVIEW_DELEGATE_TYPE*)webViewDelegate handler:(WVJBHandler)handler resourceBundle:(NSBundle*)bundle;
3131
+ (void)enableLogging;
32+
+ (void)setLogMaxLength:(int)length;
3233

3334
- (void)send:(id)message;
3435
- (void)send:(id)message responseCallback:(WVJBResponseCallback)responseCallback;

WebViewJavascriptBridge/WebViewJavascriptBridge.m

100644100755
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ @implementation WebViewJavascriptBridge {
2929
*****/
3030

3131
+ (void)enableLogging { [WebViewJavascriptBridgeBase enableLogging]; }
32+
+ (void)setLogMaxLength:(int)length { [WebViewJavascriptBridgeBase setLogMaxLength:length]; }
3233

3334
+ (instancetype)bridgeForWebView:(WVJB_WEBVIEW_TYPE*)webView handler:(WVJBHandler)handler {
3435
return [self bridgeForWebView:webView webViewDelegate:nil handler:handler];

WebViewJavascriptBridge/WebViewJavascriptBridgeBase.h

100644100755
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ typedef NSDictionary WVJBMessage;
2929
@property NSUInteger numRequestsLoading;
3030

3131
+ (void)enableLogging;
32+
+ (void)setLogMaxLength:(int)length;
3233
- (id)initWithHandler:(WVJBHandler)messageHandler resourceBundle:(NSBundle*)bundle;
3334
- (void)reset;
3435
- (void)sendData:(id)data responseCallback:(WVJBResponseCallback)responseCallback handlerName:(NSString*)handlerName;

WebViewJavascriptBridge/WebViewJavascriptBridgeBase.m

100644100755
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@ @implementation WebViewJavascriptBridgeBase {
1515
}
1616

1717
static bool logging = false;
18+
static int logMaxLength = 500;
1819

1920
+ (void)enableLogging { logging = true; }
21+
+ (void)setLogMaxLength:(int)length { logMaxLength = length;}
2022

2123
-(id)initWithHandler:(WVJBHandler)messageHandler resourceBundle:(NSBundle*)bundle
2224
{
@@ -213,8 +215,8 @@ - (void)_log:(NSString *)action json:(id)json {
213215
if (![json isKindOfClass:[NSString class]]) {
214216
json = [self _serializeMessage:json pretty:YES];
215217
}
216-
if ([json length] > 500) {
217-
NSLog(@"WVJB %@: %@ [...]", action, [json substringToIndex:500]);
218+
if ([json length] > logMaxLength) {
219+
NSLog(@"WVJB %@: %@ [...]", action, [json substringToIndex:logMaxLength]);
218220
} else {
219221
NSLog(@"WVJB %@: %@", action, json);
220222
}

0 commit comments

Comments
 (0)