fix(members): simplify email change sign-in banner

Author: markgoho

members/src/app/auth-actions/auth-actions.spec.ts

@@ -71,8 +71,7 @@ describe('AuthActions - Unit Tests', () => {
         expect(syncAuthEmailToMember).not.toHaveBeenCalled();
         expect(navigateSpy).toHaveBeenCalledWith(['/sign-in'], {
           queryParams: {
-            emailChanged: 'true',
-            message: 'Your email was updated. Please sign in again with your new email.',
+            message: 'email-changed',
           },
         });
       });
@@ -93,8 +92,7 @@ describe('AuthActions - Unit Tests', () => {
         expect(syncAuthEmailToMember).not.toHaveBeenCalled();
         expect(navigateSpy).toHaveBeenCalledWith(['/sign-in'], {
           queryParams: {
-            emailChanged: 'true',
-            message: 'Your email was updated. Please sign in again with your new email.',
+            message: 'email-changed',
           },
         });
       });
@@ -125,8 +123,7 @@ describe('AuthActions - Unit Tests', () => {
         expect(syncAuthEmailToMember).not.toHaveBeenCalled();
         expect(navigateSpy).toHaveBeenCalledWith(['/sign-in'], {
           queryParams: {
-            emailChanged: 'true',
-            message: 'Your email was updated. Please sign in again with your new email.',
+            message: 'email-changed',
           },
         });
       });

members/src/app/auth-actions/auth-actions.ts

@@ -89,8 +89,7 @@ export class AuthActions {
     if (shouldSyncMemberEmail) {
       await this.router.navigate(['/sign-in'], {
         queryParams: {
-          emailChanged: 'true',
-          message: 'Your email was updated. Please sign in again with your new email.',
+          message: 'email-changed',
         },
       });
       this.processingState.set('success');

members/src/app/sign-in/sign-in.html

@@ -15,6 +15,12 @@ <h1>Welcome Back</h1>
   </div>
 }
 
+@if (message() === 'email-changed') {
+  <div class="form__info-message">
+    Your email was updated. Please sign in again with your new email.
+  </div>
+}
+
 @if (errorMessage(); as error) {
   <div class="form__error-message">
     {{ error }}

members/src/app/sign-in/sign-in.spec.ts

@@ -123,7 +123,7 @@ describe('SignIn', () => {
 
   it('should sync member email after sign-in when redirected from email change flow', async () => {
     const { user, syncAuthEmailToMember } = await setup({
-      emailChanged: 'true',
+      message: 'email-changed',
     });
 
     await user.type(screen.getByLabelText('Email Address'), 'test@example.com');
@@ -137,7 +137,7 @@ describe('SignIn', () => {
 
   it('should show sync errors after sign-in when email recovery sync fails', async () => {
     const { user } = await setup({
-      emailChanged: 'true',
+      message: 'email-changed',
       syncEmailError: new Error('You must be signed in to update your email.'),
     });
 
@@ -153,15 +153,15 @@ interface SetupOptions {
   signInError?: Error;
   signInDelay?: number;
   signInImplementation?: () => Promise<void>;
-  emailChanged?: string;
+  message?: string;
   syncEmailError?: Error;
 }
 
 async function setup({
   signInError,
   signInDelay,
   signInImplementation,
-  emailChanged,
+  message,
   syncEmailError,
 }: SetupOptions = {}) {
   const mockAuthService = {
@@ -196,7 +196,7 @@ async function setup({
       },
       provideRouter([]),
     ],
-    bindings: [inputBinding('emailChanged', () => emailChanged)],
+    bindings: [inputBinding('message', () => message)],
   });
 
   const user = userEvent.setup();

members/src/app/sign-in/sign-in.ts

@@ -17,7 +17,6 @@ export class SignIn {
   private fb = inject(FormBuilder);
 
   message = input<string>();
-  emailChanged = input<string>();
 
   signInForm: FormGroup = this.fb.group({
     email: ['', [Validators.required.bind(this), Validators.email.bind(this)]],
@@ -37,7 +36,7 @@ export class SignIn {
 
         await this.authService.signInWithEmail(email, password);
 
-        if (this.emailChanged() === 'true') {
+        if (this.message() === 'email-changed') {
           await this.membershipService.syncAuthEmailToMember();
         }