fix: clear optimistic profile data when all retries are exhausted

The optimistic profile feature masked the error state when GET requests
permanently failed after profile creation. Now clears optimistic data
once auto-retries are exhausted so the "Profile Load Error" UI appears.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: markgoho

members/src/app/edit-profile/edit-profile.ts

@@ -49,6 +49,8 @@ export class EditProfile {
         setTimeout(() => {
           this.profileService.profileResource.reload();
         }, RETRY_DELAY_MS);
+      } else if (status === 'error' && this.autoRetryCount >= MAX_AUTO_RETRIES) {
+        this.profileService.clearOptimisticProfile();
       }
     });
   }

members/src/app/services/profile.service.ts

@@ -217,6 +217,10 @@ export class ProfileService {
     return firstValueFrom(this.http.get<ProfileData>(`/api/profiles/${slug}`));
   }
 
+  clearOptimisticProfile(): void {
+    this.optimisticProfile.set(undefined);
+  }
+
   getTagUrl(tag: string): string {
     return tag.toLowerCase().replaceAll(/\s+/g, '-');
   }