chore(functions): remove unnecessary type assertions

Auto-fix from eslint --fix to clear pre-existing
@typescript-eslint/no-unnecessary-type-assertion errors that were
failing CI.

Author: markgoho

functions/src/admin-match-requests-api/plugins/admin-match-requests-plugin.ts

@@ -85,7 +85,7 @@ export function createAdminMatchRequestsPlugin(services?: PartialServices) {
               logger,
               set,
             }) => {
-              const typedBody = body as { sent: boolean };
+              const typedBody = body;
               return updateMatchRequestLogic({
                 requestId: params.requestId,
                 sent: typedBody.sent,

functions/src/admin-members-api/plugins/admin-members-plugin.ts

@@ -1,6 +1,5 @@
 import { Elysia } from "elysia";
 import { logger as firebaseLogger } from "firebase-functions/v2";
-import type { ProfileDataBody } from "../../profiles-api/schemas/profile-schemas.js";
 import { ProfileDataBodySchema } from "../../profiles-api/schemas/profile-schemas.js";
 import { AuthService } from "../../shared-api/services/auth/index.js";
 import { EmailService } from "../../shared-api/services/email/index.js";
@@ -254,7 +253,7 @@ export function createAdminMembersPlugin(services?: PartialServices) {
               logger,
               set,
             }) => {
-              const typedBody = body as ProfileDataBody;
+              const typedBody = body;
               return updateProfileLogic({
                 memberId: params.memberId,
                 profileData: typedBody,
@@ -280,7 +279,7 @@ export function createAdminMembersPlugin(services?: PartialServices) {
               logger,
               set,
             }) => {
-              const typedBody = body as { slug: string };
+              const typedBody = body;
               return linkProfileLogic({
                 memberId: params.memberId,
                 slug: typedBody.slug,
@@ -366,7 +365,7 @@ export function createAdminMembersPlugin(services?: PartialServices) {
                   logger,
                   set,
                 }) => {
-                  const typedBody = body as { newExpirationDate: string };
+                  const typedBody = body;
                   return extendMembershipLogic({
                     memberId: params.memberId,
                     newExpirationDate: typedBody.newExpirationDate,
@@ -423,7 +422,7 @@ export function createAdminMembersPlugin(services?: PartialServices) {
               logger,
               set,
             }) => {
-              const typedBody = body as { admin?: boolean };
+              const typedBody = body;
               return updateClaimsLogic({
                 uid: params.memberId,
                 claims: typedBody,

functions/src/admin-members-api/routes/approve-profile.ts

@@ -47,6 +47,6 @@ export async function approveProfileLogic({
       logger,
       set,
       context: { memberId, adminUid },
-    }) as ApproveProfileApiResponse;
+    });
   }
 }

functions/src/admin-members-api/services/update-profile.ts

@@ -100,6 +100,6 @@ function isFirestoreNotFoundError(error: unknown): boolean {
     typeof error === "object" &&
     error !== null &&
     "code" in error &&
-    (error as { code: unknown }).code === NOT_FOUND_CODE
+    error.code === NOT_FOUND_CODE
   );
 }

functions/src/admin-members-api/test-utils/create-admin-test-plugin.ts

@@ -1,6 +1,5 @@
 import { mock } from "bun:test";
 import type { DecodedIdToken } from "firebase-admin/auth";
-import type { ProfileDocument } from "../../collections/index.js";
 import type { AuthService } from "../../shared-api/services/auth/interface.js";
 import type { EmailServiceInterface } from "../../shared-api/services/email/index.js";
 import type { Logger } from "../../shared-api/types/logger.js";
@@ -95,7 +94,7 @@ export function createAdminTestPlugin(overrides?: {
           draft: false,
           createdAt: "2024-01-01T00:00:00.000Z",
           updatedAt: "2024-01-01T00:00:00.000Z",
-        } as ProfileDocument,
+        },
       }),
     ),
     updateProfile: mock(() =>
@@ -107,7 +106,7 @@ export function createAdminTestPlugin(overrides?: {
           draft: false,
           createdAt: "2024-01-01T00:00:00.000Z",
           updatedAt: "2024-02-01T00:00:00.000Z",
-        } as ProfileDocument,
+        },
       }),
     ),
     listUnlinkedProfiles: mock(() =>

functions/src/admin-messages-api/plugins/admin-messages-plugin.ts

@@ -81,7 +81,7 @@ export function createAdminMessagesPlugin(services?: PartialServices) {
               logger,
               set,
             }) => {
-              const typedBody = body as { sent: boolean };
+              const typedBody = body;
               return updateMessageLogic({
                 messageId: params.messageId,
                 sent: typedBody.sent,

functions/src/profiles-api/routes/create-profile.ts

@@ -134,6 +134,6 @@ export async function createProfileLogic({
       set,
       context: { uid },
     });
-    return errorResponse as CreateProfileResponse;
+    return errorResponse;
   }
 }

functions/src/profiles-api/services/profile-store/create-profile.ts

@@ -83,6 +83,6 @@ function isFirestoreAlreadyExistsError(error: unknown): boolean {
     typeof error === "object" &&
     error !== null &&
     "code" in error &&
-    (error as { code: unknown }).code === ALREADY_EXISTS_CODE
+    error.code === ALREADY_EXISTS_CODE
   );
 }

functions/src/profiles-api/services/profile-store/write-profile.ts

@@ -89,6 +89,6 @@ function isFirestoreNotFoundError(error: unknown): boolean {
     typeof error === "object" &&
     error !== null &&
     "code" in error &&
-    (error as { code: unknown }).code === NOT_FOUND_CODE
+    error.code === NOT_FOUND_CODE
   );
 }

functions/src/test-utils/stripe-test-helpers.ts

@@ -87,7 +87,7 @@ export function createMockCheckoutEvent(options: {
       idempotency_key: null,
     },
     type: "checkout.session.completed",
-  } as Stripe.Event;
+  };
 }
 
 /**